Skip to content

Add outlier detection failure matcher#3741

Open
Samarth6840 wants to merge 3 commits into
istio:masterfrom
Samarth6840:add-outlier-detection-failure-matcher
Open

Add outlier detection failure matcher#3741
Samarth6840 wants to merge 3 commits into
istio:masterfrom
Samarth6840:add-outlier-detection-failure-matcher

Conversation

@Samarth6840

Copy link
Copy Markdown

What this PR does

Adds outlier_detection_http_error_codes to OutlierDetection in DestinationRule,
allowing users to specify additional HTTP status codes (beyond the default 5xx) to
be treated as outlier detection failures.

Maps to Envoy's new outlier_detection.failure_matcher in HttpProtocolOptions
(envoyproxy/envoy#39947).

Follows the same simplification pattern as consecutiveGatewayErrors /
consecutive5xxErrors (#1189) — a plain repeated field rather than exposing
Envoy's raw MatchPredicate, consistent with Istio's existing approach (e.g.
VirtualService's retryOn).

Related

Implements the API portion of istio/istio#60828

Next steps

Wiring into istio/istio's cluster_traffic_policy.go (HttpProtocolOptions
section) will follow in a separate PR.

@Samarth6840 Samarth6840 requested a review from a team as a code owner July 11, 2026 05:44
@istio-policy-bot

Copy link
Copy Markdown

😊 Welcome @Samarth6840! This is either your first contribution to the Istio api repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@linux-foundation-easycla

linux-foundation-easycla Bot commented Jul 11, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test labels Jul 11, 2026
@istio-testing

Copy link
Copy Markdown
Collaborator

Hi @Samarth6840. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Samarth6840 Samarth6840 force-pushed the add-outlier-detection-failure-matcher branch from aa6b8ce to 0ab9dbe Compare July 11, 2026 05:56
@ramaraochavali

Copy link
Copy Markdown
Contributor

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Jul 13, 2026
@istio-testing

Copy link
Copy Markdown
Collaborator

@Samarth6840: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
release-notes_api 1d458eb link false /test release-notes
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants