Add outlier detection failure matcher#3741
Conversation
|
😊 Welcome @Samarth6840! This is either your first contribution to the Istio api repo, or it's been You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
|
Hi @Samarth6840. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
aa6b8ce to
0ab9dbe
Compare
|
/ok-to-test |
|
@Samarth6840: The following test failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What this PR does
Adds
outlier_detection_http_error_codestoOutlierDetectionin DestinationRule,allowing users to specify additional HTTP status codes (beyond the default 5xx) to
be treated as outlier detection failures.
Maps to Envoy's new
outlier_detection.failure_matcherinHttpProtocolOptions(envoyproxy/envoy#39947).
Follows the same simplification pattern as
consecutiveGatewayErrors/consecutive5xxErrors(#1189) — a plain repeated field rather than exposingEnvoy's raw MatchPredicate, consistent with Istio's existing approach (e.g.
VirtualService's
retryOn).Related
Implements the API portion of istio/istio#60828
Next steps
Wiring into
istio/istio'scluster_traffic_policy.go(HttpProtocolOptionssection) will follow in a separate PR.