Cleanup comments in remove_dead.F90 - #84
Merged
Merged
Conversation
danielhollas
commented
Jul 20, 2026
| implicit none | ||
|
|
||
| !> OMax: This is a legacy threshold value that functioned | ||
| !> OMax is a legacy threshold value that functioned |
Member
Author
There was a problem hiding this comment.
These were generating warnings in Ford build:
Warning: In 'SpawnModule.f90:OMAX_DEFAULT': Ignoring unknown Ford metadata key 'omax'
Warning: In 'SpawnModule.f90:OMax_inter': Ignoring unknown Ford metadata key 'omax_inter'
Warning: In 'SpawnModule.f90:OMax_intra': Ignoring unknown Ford metadata key 'omax_intra'
Warning: In 'SpawnModule.f90:OMin_parent': Ignoring unknown Ford metadata key 'omin_parent'
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
=======================================
Coverage 65.49% 65.49%
=======================================
Files 42 42
Lines 7511 7511
Branches 979 979
=======================================
Hits 4919 4919
Misses 2198 2198
Partials 394 394 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
yoricklassmann
approved these changes
Jul 20, 2026
yoricklassmann
left a comment
yoricklassmann
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.