guard pod creation on non-terminal sandbox state - #399
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6ff97adbfb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // whose pod was garbage-collected out-of-band must not re-run its workload. | ||
| isTerminal := meta.FindStatusCondition(sandbox.Status.Conditions, sandboxv1alpha1.SandboxSucceededCondition) != nil | ||
|
|
||
| if sandboxPod == nil && !isTerminal { |
There was a problem hiding this comment.
In the out-of-band GC case this condition now skips pod creation, but the terminal sandbox still falls through to reconcileSandboxStatus(..., nil) below. That helper derives Ready/PodReady from a nil pod as PodPending, so after a succeeded or failed workload loses its pod, the controller overwrites the terminal PodSucceeded/PodFailed Ready reason (the CRD's Reason column is sourced from Ready) even though no pod is pending. Please return before the nil-pod status reconciliation or preserve terminal Ready/PodReady conditions.
Useful? React with 👍 / 👎.
1 participant
No description provided.