kill command process group on cancel - #394
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a880bd2c69
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| func processAlive(pid int) bool { | ||
| return syscall.Kill(pid, 0) == nil |
There was a problem hiding this comment.
In environments where PID 1 does not promptly reap orphaned children, the child killed by the process-group SIGKILL remains as a zombie reparented to PID 1; kill(pid, 0) still returns nil for zombies. That makes the new Eventually(... processAlive(childPID) ...).Should(BeFalse()) assertions time out even though the child is no longer running, so these tests fail/flap in containerized CI. Consider checking /proc/<pid>/status and treating State: Z as exited, or arranging for the child to be reaped.
Useful? React with 👍 / 👎.
1 participant
No description provided.