This repository was archived by the owner on Apr 20, 2026. It is now read-only.
[sa-submission-q1-2026] Add numa core binding for all gb200 and gb300 configs#164
Open
trevor-m wants to merge 1 commit into
Open
[sa-submission-q1-2026] Add numa core binding for all gb200 and gb300 configs#164trevor-m wants to merge 1 commit into
trevor-m wants to merge 1 commit into
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
@ishandhanani Shall we merge that one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Grace-blackwell systems are composed of two numa nodes. Node 0 contains GPUs 0,1 and cpu cores 0-71. Node 1 contains GPUs 2,3 and cpu cores 72-144. Each numa node also has a unified memory between its cpus and gpus. This PR ensures that worker processes are bound to the correct numa node for their gpu that they are assigned to.