Skip to content

selection_extract: clamp row index before grid access (fixes segfault on drag-to-other-window) #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blshkv wants to merge 1 commit into
base: master
Choose a base branch
from
Open

selection_extract: clamp row index before grid access (fixes segfault on drag-to-other-window) #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions glass.asm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11611,12 +11611,16 @@ selection_extract:
.se_row_grid_shifted:
mov rax, r12
sub rax, [scroll_offset]
cmp rax, MAX_ROWS ; guard: shifted row must be in [0, MAX_ROWS)
jge .se_done
imul rax, MAX_COLS
imul rax, CELL_SIZE
lea rbx, [grid + rax]
jmp .se_row_base_done
.se_row_live:
mov rax, r12
cmp rax, MAX_ROWS ; guard: row must be in [0, MAX_ROWS)
jge .se_done
imul rax, MAX_COLS
imul rax, CELL_SIZE
lea rbx, [grid + rax]
Expand Down