fix: Preserve match data in endpoint interpolation functions#23
Open
jasonatwell wants to merge 1 commit into
Open
fix: Preserve match data in endpoint interpolation functions#23jasonatwell wants to merge 1 commit into
jasonatwell wants to merge 1 commit into
Conversation
The `#{project}` and `#{group}` placeholders are replaced via
`s-replace-regexp' with function replacements, and
`replace-regexp-in-string' uses its own match data to splice the
function's return value back into the string. `lab--project-path'
runs regexps of its own which clobber that match data, so the
replacement got spliced over the wrong span of the endpoint:
projects/#{projname%2Fui%2Frepo-name}/merge_requests
The stray `#' then truncates the request path as a URL fragment, so
GitLab receives POST /api/v4/projects and rejects it with "name, path
are missing". SSH/SCP-style remotes dodge the bug by taking a
different parse path, which is why it only shows up with https
remotes. Wrap both replacement functions in `save-match-data'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
#{project}and#{group}placeholders are replaced vias-replace-regexpwith function replacements, andreplace-regexp-in-stringuses its own match data to splice the function's return value back into the string.lab--project-pathruns regexps of its own which clobber that match data, so the replacement got spliced over the wrong span of the endpoint:projects/#{projname%2Fui%2Frepo-name}/merge_requests. The stray#then truncates the request path as a URL fragment, so GitLab receivesPOST /api/v4/projectsand rejects it with "name, path are missing". SSH/SCP-style remotes dodge the bug by taking a different parse path, which is why it only shows up with https remotes. Wrap both replacement functions insave-match-data.disclaimer: 100% vibe coded by Fable 5