-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Integrate articulation ordering caches and selectors #6784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kellyguo11
merged 168 commits into
isaac-sim:develop
from
AntoineRichard:antoiner/articulation-reordering-integration
Aug 1, 2026
Merged
Changes from all commits
Commits
Show all changes
168 commits
Select commit
Hold shift + click to select a range
d2956d2
Encapsulate the articulation element kind into a type
AntoineRichard 80e2fbf
Wire articulation ordering into the OVPhysX backend
AntoineRichard 0b0601b
Adapt OVPhysX backend to reworked ordering core
AntoineRichard 3582dd5
Adapt OVPhysX backend to merged ordering buffer helper
AntoineRichard 063e866
Add cross-backend articulation ordering interface tests
AntoineRichard c6ca69d
Adapt ordering iface tests to reworked core
AntoineRichard 0921523
Remove duplicate backend discovery regression
AntoineRichard 802fcb8
Adopt articulation ordering in events, consumers, and docs
AntoineRichard 6e9adaa
Restore Newton identity write fast path
AntoineRichard 968ad54
Deprecate removed articulation data kernels
AntoineRichard d9a07e6
Reference cfg fields in ordering diagnostics
AntoineRichard d4d4ec2
Trim redundant ordering event map tests
AntoineRichard effcea1
Right-size ordering interface test matrix
AntoineRichard 9b770cd
Relocate map application tests to the core suite
AntoineRichard 753a602
Avoid aliasing the effort output in the ordered write launch
AntoineRichard 855c6f2
Name telemetry kernel indices by their order space
AntoineRichard 7265a25
Clarify post-step callback fires once per step
AntoineRichard da963b7
Adopt ordering-presence properties in Newton write_data_to_sim
AntoineRichard 4b64291
Cache articulation ordering read launches
AntoineRichard 37c3614
Expand articulation read launch caching
AntoineRichard 2c640cf
Handle empty cached read launches
AntoineRichard dc5d3aa
Add Warp index kernel dispatcher
AntoineRichard 51a5d27
Format Warp index kernel dispatcher
AntoineRichard 8cdfa8c
Document Warp index kernel dispatcher
AntoineRichard f3819c9
Broaden shared Warp index kernels
AntoineRichard 04356e4
Support int64 PhysX selectors
AntoineRichard 0015415
Move Newton selector casts into kernels
AntoineRichard 42595f7
Suppress Newton test import warning
AntoineRichard e60bbdb
Support int64 OVPhysX selectors
AntoineRichard b29e4d0
Fix OVPhysX selector factory routing
AntoineRichard 8cb1352
Benchmark Warp selector dtypes
AntoineRichard 5b27d04
Fix benchmark copyright header
AntoineRichard d68f15c
Document articulation selector support
AntoineRichard 16e3908
Fix raw index kernel compatibility
AntoineRichard 576755c
Normalize external environment selectors
AntoineRichard 41d3ab5
Guard external selector sentinels
AntoineRichard ab793b2
Fix deferred selector validation
AntoineRichard c1c1c41
Add per-asset selector cache
AntoineRichard d8ee45d
Accept proxy selectors in index kernels
AntoineRichard be4d99f
Fix Newton proxy factory annotation test
AntoineRichard 7c58ee2
Test proxy selector factory edge cases
AntoineRichard 38d8a5d
Add proxy return mode to asset finders
AntoineRichard 290a7ef
Return cached proxies from asset finders
AntoineRichard 33950cd
Handle empty proxy selector views
AntoineRichard 587d80d
Use explicit asset finder representations
AntoineRichard fec58f1
Tighten actuator selector handling
AntoineRichard caaec11
Benchmark cached proxy selectors
AntoineRichard 0f0d627
Tighten selector benchmark boundaries
AntoineRichard 42f1115
Document cached asset finder proxies
AntoineRichard 28f526e
Clarify cached finder documentation
AntoineRichard 0fa6647
Format selector kernel tests
AntoineRichard a4e6837
Fix cached proxy selector consumers
AntoineRichard 6e9c336
Harden proxy selector benchmarks
AntoineRichard bcd2b45
Document proxy finder migration
AntoineRichard 44ea335
Enforce expected selector benchmark modes
AntoineRichard 89b90cf
Complete cached finder migration contracts
AntoineRichard 6fedeab
Move articulation kind protocols into type
AntoineRichard e3ba853
Enforce articulation kind singletons
AntoineRichard 03300c4
Wire articulation ordering into the OVPhysX backend
AntoineRichard 7e27272
Adapt OVPhysX backend to reworked ordering core
AntoineRichard 1222e6e
Adapt OVPhysX backend to merged ordering buffer helper
AntoineRichard d7f3e1d
Document P6 review cleanup design
AntoineRichard 23fb0c0
Fix ordered indexed joint state writes
AntoineRichard be22fd7
Simplify OVPhysX articulation writes
AntoineRichard fd12808
Simplify OVPhysX ordering staging
AntoineRichard c96a895
Clarify OVPhysX ordering tests
AntoineRichard fe1a5ed
Remove stale articulation helper raises
AntoineRichard b203d5a
Document P6 review follow-up design
AntoineRichard 8c34c4b
Clarify P6 property staging design
AntoineRichard 0833c01
Add live OVPhysX ordered target coverage
AntoineRichard 317592d
Consolidate OVPhysX property reads
AntoineRichard 2e7ecc5
Consolidate OVPhysX property writes
AntoineRichard c0cc65f
Complete OVPhysX ordering changelog
AntoineRichard b46fc72
Fix ordered OVPhysX position limit staging
AntoineRichard 8ee2c17
Remove internal P6 review specs
AntoineRichard 5d12718
Add cross-backend articulation ordering interface tests
AntoineRichard 3a9e440
Adapt ordering iface tests to reworked core
AntoineRichard c9e2284
Remove duplicate backend discovery regression
AntoineRichard 2dbd5dd
Add shared articulation ordering fixtures
AntoineRichard 37fed30
Share articulation ordering test fixtures
AntoineRichard f9dbbe3
Filter mock backend case-insensitively
AntoineRichard edf5ffa
Fix structured mock tensor reads
AntoineRichard 5ec72fd
Fix OVPhysX mock write capabilities
AntoineRichard 8461318
Guard mock binding dtype reinterpretation
AntoineRichard f3a9841
Fix shared ordering fixture references
AntoineRichard 7a16d22
Fix Newton shared ordering references
AntoineRichard ea9170d
Adopt articulation ordering in events, consumers, and docs
AntoineRichard 60e7228
Restore Newton identity write fast path
AntoineRichard 39422ac
Reference cfg fields in ordering diagnostics
AntoineRichard 0c3692b
Trim redundant ordering event map tests
AntoineRichard dca0eda
Right-size ordering interface test matrix
AntoineRichard 0cc92a5
Relocate map application tests to the core suite
AntoineRichard fb7f8f3
Avoid aliasing the effort output in the ordered write launch
AntoineRichard e77e394
Name telemetry kernel indices by their order space
AntoineRichard ad9792d
Clarify post-step callback fires once per step
AntoineRichard 7431fc6
Adopt ordering-presence properties in Newton write_data_to_sim
AntoineRichard e9ab91b
Fix Newton ordering fixture reference
AntoineRichard d9dc963
Fix Newton material randomization mock
AntoineRichard 87dacd6
Cache articulation ordering read launches
AntoineRichard 29198b6
Expand articulation read launch caching
AntoineRichard e4882ba
Handle empty cached read launches
AntoineRichard f8cb530
Add cached read empty launch tests
AntoineRichard 5a00c43
Add changelog migration guidance
AntoineRichard 52978c8
Fix rigid asset state cache invalidation
AntoineRichard 88bf44f
Fix OVPhysX interface test harness
AntoineRichard 47838d6
Fix COM-dependent asset cache invalidation
AntoineRichard 251f904
Cache articulation ordering read launches
AntoineRichard 1b3d3f4
Expand articulation read launch caching
AntoineRichard a3d975a
Handle empty cached read launches
AntoineRichard 67b8460
Add cached read empty launch tests
AntoineRichard e79b9f2
Add changelog migration guidance
AntoineRichard 00c869a
Add OvPhysX articulation dynamics
AntoineRichard 8bd23d9
Cache OvPhysX articulation reads
AntoineRichard 5659b7a
Merge articulation element kind refactor
AntoineRichard f4bae89
Merge cached articulation reads
AntoineRichard 3384f04
Merge rigid asset cache invalidation
AntoineRichard cebcb62
Merge articulation selector APIs
AntoineRichard c7aee2f
Consolidate aggregate changelog fragments
AntoineRichard 6f649e1
Update aggregate changelog contracts
AntoineRichard 6c9b88d
Fix articulation selector parity regressions
AntoineRichard 19cfb1c
Default finder selectors to legacy mode
AntoineRichard 57dc783
Remove redundant legacy finder arguments
AntoineRichard e496523
Test scene entity finder behavior
AntoineRichard 9107831
Align finder default documentation
AntoineRichard c28b393
Remove redundant finder proxy flags
AntoineRichard 2c4d8d8
Merge branch 'develop' into antoiner/articulation-reordering-integration
kellyguo11 5ac115e
Merge remote-tracking branch 'origin/develop' into antoiner/articulat…
AntoineRichard edaaf56
Add shared selector benchmark modes
AntoineRichard e39b0a7
Benchmark cold and cached asset finders
AntoineRichard 33a2048
Integrate index kernel dtype benchmark
AntoineRichard e3d4c60
Document selector benchmark grid
AntoineRichard c452a7e
Fix benchmark device and config compatibility
AntoineRichard e3cca1e
Merge remote PR branch
AntoineRichard 8b10b48
Restrict index dispatch to Torch and Warp
AntoineRichard 1eb7eb6
Remove proxy selector factory inputs
AntoineRichard 59e9e37
Make proxy selector outputs explicit
AntoineRichard c8c5a9d
Select explicit internal index views
AntoineRichard 8c5927d
Align selector benchmarks with public inputs
AntoineRichard 397d26f
Clean selector review leftovers
AntoineRichard c886006
Simplify index kernel benchmark timing
AntoineRichard 99745b9
Trim selector integration coverage
AntoineRichard 7d1b34e
Merge remote-tracking branch 'origin/develop' into antoiner/articulat…
AntoineRichard 0c4dd37
Trim articulation benchmark scaffolding
AntoineRichard d8bee62
Simplify selector benchmark dispatch
AntoineRichard f38ba4e
Remove redundant index compatibility paths
AntoineRichard 3a10c0a
Add cached Warp read launches
AntoineRichard a7be0ca
Consolidate articulation read launch caching
AntoineRichard 024a6ae
Cache PhysX rigid asset reads
AntoineRichard ada40d6
Cache Newton rigid asset reads
AntoineRichard 1401953
Cache OVPhysX rigid asset reads
AntoineRichard fec8ce4
Fix articulation velocity cache invalidation
AntoineRichard 2a605d7
Normalize reversed-joint dynamics reads
AntoineRichard 0465a24
Prototype OVPhysX selector scratch
AntoineRichard 1fea108
Revert OVPhysX selector scratch prototype
AntoineRichard dea2965
Prototype OVPhysX selector masks
AntoineRichard 7a25c29
Select OVPhysX selector scratch
AntoineRichard fc146c0
Add OVPhysX dynamics mock bindings
AntoineRichard a4c6c4b
Fix OVPhysX scratch kernel launch
AntoineRichard 19e72de
Address articulation integration feedback
AntoineRichard c40c3d9
Fix empty articulation joint writes
AntoineRichard 45f5298
Expand asset selector benchmarks
AntoineRichard 00c8c25
Reuse simulator index scratch
AntoineRichard a83b390
Fix asset selector review issues
AntoineRichard 1bb2de3
Fix PhysX interface selector setup
AntoineRichard 72bd9e6
Fix PhysX collection interface setup
AntoineRichard 9cc1ee7
Keep OVPhysX tests out of core shard
AntoineRichard 87db7fa
Merge branch 'develop' into antoiner/articulation-reordering-integration
AntoineRichard 3e4faac
Merge branch 'develop' into antoiner/articulation-reordering-integration
kellyguo11 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 21 additions & 0 deletions
21
source/isaaclab/changelog.d/antoiner-articulation-reordering-integration.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| Added | ||
| ^^^^^ | ||
|
|
||
| * Added the ``as_proxy`` return-mode option to asset finder methods. | ||
| ``as_proxy=False`` is the default and returns the legacy selector | ||
| representation, while ``as_proxy=True`` opts into cached | ||
| :class:`~isaaclab.utils.warp.ProxyArray` selectors with zero-copy ``.torch`` | ||
| and ``.warp`` index views. Pass those explicit views to downstream APIs. | ||
| * Added a shared asset micro-benchmark grid for Torch and Warp item selectors, | ||
| cold and cached finder calls, and signed 32-bit versus signed 64-bit | ||
| articulation index-kernel timings. | ||
|
|
||
| Fixed | ||
| ^^^^^ | ||
|
|
||
| * Fixed shared articulation ordering and external wrench paths to accept signed | ||
| 32-bit and signed 64-bit selectors without allocating Torch conversion tensors. | ||
| * Fixed manager entity resolution for sensors with legacy body finder signatures. | ||
| * Fixed external wrench composition to consume explicit Warp views of cached | ||
| body selectors without materializing Torch tensors. | ||
| * Fixed articulation dynamics reads for reversed USD joint relationships. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we qualify this requirement? The prerequisites table now says PhysX asset benchmarks run kitless with mocked PhysX views, and the asset runtime no longer launches the app. Isaac Sim is still required for the PhysX sensor benchmarks, but not for the asset benchmarks described above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in a83b390. The troubleshooting text now states that PhysX sensor benchmarks require Isaac Sim; the kitless PhysX asset benchmark requirement remains as documented in the prerequisites table.