Repository navigation
Fill: Auto Fill Options button after a fill drag (#1403) - #7
Draft
isaac-levine wants to merge 498 commits into
Draft
isaac-levine wants to merge 498 commits into
isaac-levine wants to merge 498 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ame test Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… where dbus-daemon is missing Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…m-autofilter-is-less-than-l
…ength # Conflicts: # docs/localization-parity.md
…-left-sheets # Conflicts: # docs/file-format-parity.md # docs/localization-parity.md
# Conflicts: # docs/file-format-parity.md # docs/localization-parity.md
# Conflicts: # docs/file-format-parity.md
# Conflicts: # docs/ui-parity.md
# Conflicts: # docs/file-format-parity.md
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…press Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # docs/file-format-parity.md # docs/localization-parity.md
…ef-parse-accepts-signed-ro
…p-theme-watcher-opens-a-ne
…uchscreen-devices-cannot-p
…anslations # Conflicts: # crates/ui-egui/src/i18n.rs # docs/localization-parity.md
…itor-references docs: drop references to competing commercial software
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Adds .coderabbit.yaml so CodeRabbit no longer reviews or comments on PRs opened by dependabot[bot]. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…kflow ci: switch to shared nix workflow from craft-common-actions
The button sits at the corner of the filled range and offers Copy Cells, Fill Series, Fill Formatting Only and Fill Without Formatting. Choosing one undoes the drag and redoes it in that mode. Fill Without Formatting now extends the series instead of copying the first value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dragging the fill handle only ever produced one result. Issue storytold#1403 asks for the option to pick between filling a series and copying cells after the drag.
The engine already has the modes in
edit.autoFill, so this adds the missing UI step. After a fill drag a small button shows at the bottom-right corner of the filled range. Its menu has Copy Cells, Fill Series, Fill Formatting Only and Fill Without Formatting. Choosing one runsedit.undoand thenedit.autoFillagain with that mode, so the history keeps a single fill entry. The button goes away when the selection moves or any other edit lands. I also changed the engine'svaluesmode so Fill Without Formatting extends the series like a plain drag, instead of copying the first value.Commands run:
cargo fmt --all -- --check: cleancargo clippy -p gridcraft-engine -p gridcraft-ui-egui --all-targets -- -D warnings: cleancargo test -p gridcraft-engine -p gridcraft-ui-egui: all pass, including the newtests/auto_fill_options.rsandfill_without_formatting_extends_the_seriescargo xtask layers: OK.cargo xtask wasm: okNot verified: I did not look at the button in a running window or a snapshot, so its position, size and the popup styling are untested visually. I did not run
cargo xtask cias a whole, and I did not update the parity docs.Upstream issue: storytold#1403
Generated by Claude Code