Add sahnoun.json for domain configuration - #46730
Conversation
Hi there! 👋You've successfully made a pull request! Here are some steps to do while waiting for a maintainer to review the pull request:
Note: if you've opened this pull request while there is a high number of other open pull requests, your wait time will be longer than usual. Please be patient! |
There was a problem hiding this comment.
Pull request overview
This pull request adds a new domain configuration JSON file under domains/ to register the sahnoun.is-a.dev subdomain and define its DNS records.
Changes:
- Added
domains/sahnoun.jsonwithownermetadata. - Added DNS records for the subdomain (A, TXT, and CNAME entries).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| @@ -0,0 +1,23 @@ | |||
| { | |||
| "owner": { | ||
| "username": "ENSI-Sahnoun" | ||
| }, |
| { | ||
| "name": "_vercel", | ||
| "value": "vc-domain-verify=sahnoun.is-a.dev,7b378c4204525dccd010" | ||
| }, | ||
| { |
| "CNAME": { | ||
| "www": "0bac07b436429c17.vercel-dns-017.com" | ||
| } |
Requirements
Website PreviewWebsite PurposePersonal Portfolio & CTF Writeups Blog |
Removed TXT and CNAME records from the JSON file.
| "email": "work@sahnoun.dev" | ||
| }, | ||
| "records": { | ||
| "TXT": "vc-domain-verify=www.sahnoun.is-a.dev,47014c9e7b48f27cced5" |
There was a problem hiding this comment.
also should be inside domains/_vercel.sahnoun.json
Pull Request DeniedThis pull request has been denied due to the following reason(s): Invalid FileYour file and its format is invalid and fails checks. Check that your file is in the correct directory, has a valid filename, and is valid JSON. For more information, read our documentation on file structure. If you believe this was a mistake, or if you need further clarification, please feel free to create an issue or reach out to our team in the Discord server. |
Requirements
ownerkey.Website Preview
https://sahnoun.dev
Website Purpose
Personal Portfolio & CTF Writeups Blog