Skip to content

Add sahnoun.json for domain configuration - #46730

Closed
ENSI-Sahnoun wants to merge 9 commits into
is-a-dev:mainfrom
ENSI-Sahnoun:main
Closed

Add sahnoun.json for domain configuration#46730
ENSI-Sahnoun wants to merge 9 commits into
is-a-dev:mainfrom
ENSI-Sahnoun:main

Conversation

@ENSI-Sahnoun

@ENSI-Sahnoun ENSI-Sahnoun commented Aug 9, 2026

Copy link
Copy Markdown

Requirements

  • I agree to the Terms of Service.
  • My file is following the domain structure.
  • My website is reachable and completed.
  • My website is software development related.
  • My website is not for commercial use.
  • I have provided sufficient contact information in the owner key.
  • I have provided a link to my website below.

Website Preview

https://sahnoun.dev

Website Purpose

Personal Portfolio & CTF Writeups Blog

@ENSI-Sahnoun
ENSI-Sahnoun requested a review from a team as a code owner August 9, 2026 19:13
Copilot AI lite review requested due to automatic review settings August 9, 2026 19:13
@is-a-dev-reviewbot

Copy link
Copy Markdown

Hi there! 👋

You've successfully made a pull request! Here are some steps to do while waiting for a maintainer to review the pull request:

  1. Check if the checks have failed or passed. You should see the status at the bottom of the pull request or a icon next to the commit ID. You can click on the 3 dots next to the "CI / Tests" check then click "View details", it will show you the logs of the tests.
  2. Check if the filename, file format, and records are valid. If you don't know if it's valid, please read this part of the documentation and use a JSON validator/formatter, like jsonlint. Make sure that the file is in the domains directory and not somewhere else in the repository.
  3. Please make sure that you've filled out the pull request template. It is generally not a good idea to overwrite the pull request template with something else unless you know what you are doing. Make sure to add either a publicly available preview of your website or a screenshot of it.
  4. Please wait patiently. Pull requests may take between a couple hours to 3 days. All of the maintainer team are volunteers and try to review the pull requests in their spare time.
  5. Please note that mentioning maintainers in pull requests without it being reviewed could lead to you getting marked as "low priority"; this also applies to pinging the maintainers in the Discord server or messaging the maintainers in private to review the pull request.

Note: if you've opened this pull request while there is a high number of other open pull requests, your wait time will be longer than usual. Please be patient!

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds a new domain configuration JSON file under domains/ to register the sahnoun.is-a.dev subdomain and define its DNS records.

Changes:

  • Added domains/sahnoun.json with owner metadata.
  • Added DNS records for the subdomain (A, TXT, and CNAME entries).

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread domains/sahnoun.json
@@ -0,0 +1,23 @@
{
Comment thread domains/sahnoun.json
Comment on lines +2 to +4
"owner": {
"username": "ENSI-Sahnoun"
},
Comment thread domains/sahnoun.json Outdated
Comment on lines +10 to +14
{
"name": "_vercel",
"value": "vc-domain-verify=sahnoun.is-a.dev,7b378c4204525dccd010"
},
{
Comment thread domains/sahnoun.json Outdated
Comment on lines +19 to +21
"CNAME": {
"www": "0bac07b436429c17.vercel-dns-017.com"
}
@ENSI-Sahnoun

Copy link
Copy Markdown
Author

Requirements

  • I agree to the Terms of Service.
  • My file is following the domain structure.
  • My website is reachable and completed.
  • My website is software development related.
  • My website is not for commercial use.
  • I have provided sufficient contact information in the owner key.
  • I have provided a link to my website below.

Website Preview

https://sahnoun.dev

Website Purpose

Personal Portfolio & CTF Writeups Blog

"email": "work@sahnoun.dev"
},
"records": {
"TXT": "vc-domain-verify=www.sahnoun.is-a.dev,47014c9e7b48f27cced5"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also should be inside domains/_vercel.sahnoun.json

@notamitgamer notamitgamer added status: denied reason: invalid file Your file is invalid or improper. labels Aug 13, 2026
@is-a-dev-reviewbot

Copy link
Copy Markdown

Pull Request Denied

This pull request has been denied due to the following reason(s):


Invalid File

Your file and its format is invalid and fails checks. Check that your file is in the correct directory, has a valid filename, and is valid JSON. For more information, read our documentation on file structure.


If you believe this was a mistake, or if you need further clarification, please feel free to create an issue or reach out to our team in the Discord server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reason: invalid file Your file is invalid or improper. status: denied

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants