Skip to content

Properly convert action field to IRI event#744

Open
friegger wants to merge 1 commit into
mainfrom
fix/ironcore-1489-set-action-field-when-converting-to-iri-event
Open

Properly convert action field to IRI event#744
friegger wants to merge 1 commit into
mainfrom
fix/ironcore-1489-set-action-field-when-converting-to-iri-event

Conversation

@friegger

@friegger friegger commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features

    • Event listings now include an event action value in the response.
  • Bug Fixes

    • Event details shown in filtered and unfiltered event lists are now more complete and consistent.

Signed-off-by: Felix Riegger <felix.riegger@sap.com>
@friegger friegger requested a review from a team as a code owner July 8, 2026 14:19
@friegger friegger requested a review from lukasfrank July 8, 2026 14:19
@github-actions github-actions Bot added size/XS bug Something isn't working labels Jul 8, 2026
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0e8963b4-c971-468c-82c1-9c87c076a4ad

📥 Commits

Reviewing files that changed from the base of the PR and between dce5db7 and 0f2b5be.

📒 Files selected for processing (2)
  • internal/server/event_list.go
  • internal/server/integration/event_list_test.go

📝 Walkthrough

Walkthrough

This PR adds an Action field population in convertEventToIRIEvent, sourcing the value from the recorder event's Action field, and updates integration tests for ListEvents to assert this new field equals SetIgnition in two test scenarios.

Changes

Event Action field propagation

Layer / File(s) Summary
Populate and verify Action field
internal/server/event_list.go, internal/server/integration/event_list_test.go
convertEventToIRIEvent sets Action on EventSpec from the source event, and integration tests assert Action equals SetIgnition in both the no-filter and label/time-filter ListEvents cases.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: converting the action field into the IRI event.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ironcore-1489-set-action-field-when-converting-to-iri-event

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@friegger friegger added the integration-tests to run integration tests label Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working integration-tests to run integration tests size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant