Fix networkplugin cert renewal RBAC#1507
Merged
Merged
Conversation
📝 WalkthroughWalkthroughAdded RBAC rules to the ChangesNetwork Plugin RBAC Update
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
95a1f35 to
0cfe8b7
Compare
The network plugin ClusterRole only granted access to core.apinet.ironcore.dev networkinterfaces. The corresponding *-bootstrapper role, which grants create on certificatesigningrequests and certificatesigningrequests/networkpluginclient, is bound only to the bootstrap token group (system:bootstrappers:networking-ironcore-dev:networkplugins). As a result, initial bootstrap worked, but once a plugin had switched from its bootstrap kubeconfig to its issued client cert (user networking.ironcore.dev:system:networkplugin:<name>, group networking.ironcore.dev:system:networkplugins), any attempt to rotate its certificate failed with: certificatesigningrequests.certificates.k8s.io is forbidden: User "networking.ironcore.dev:system:networkplugin:<name>" cannot create resource "certificatesigningrequests" in API group "certificates.k8s.io" at the cluster scope Grant the same CSR create + networkpluginclient subresource permissions on the non-bootstrapper role so plugins can self-renew, mirroring how the machinepool, volumepool, and bucketpool roles are structured. The NetworkPluginRecognizer auto-approver in internal/controllers/core/certificate/networking/networkplugin.go already gates approval on a SubjectAccessReview against the networkpluginclient subresource, so renewal CSRs remain scoped to legitimate plugin identities. Signed-off-by: Felix Riegger <felix.riegger@sap.com>
0cfe8b7 to
7152811
Compare
hardikdr
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1508
Summary by CodeRabbit