Error converting xml to dataless

[anss-sis]

The stationxml seed converter failed to generate dataless from https://files.anss-sis.scsn.org/preview/WR_SHER.xml . Note this file is available only for a day. I was not able to attach it to the ticket, I can email it to you if you prefer.

Command ran:
/usr/bin/java -jar stationxml-seed-converter-2.1.0.jar -s -o WR_SHER.dataless WR_SHER.xml

Output:
java.lang.NumberFormatException: Couldn't format number!-150.1 -150.1 [5 6 ]
at edu.iris.dmc.io.SeedStringBuilder.appendLocalDepth(SeedStringBuilder.java:204)
at edu.iris.dmc.seed.control.station.B052.toSeedString(B052.java:296)
at edu.iris.dmc.seed.AbstractBlockette.getSize(AbstractBlockette.java:72)
at edu.iris.dmc.seed.Volume.add(Volume.java:266)
at edu.iris.dmc.station.converter.XmlToSeedDocumentConverter.convert(XmlToSeedDocumentConverter.java:112)
at edu.iris.dmc.station.converter.XmlToSeedDocumentConverter.convert(XmlToSeedDocumentConverter.java:48)
at edu.iris.dmc.station.converter.XmlToSeedFileConverter.convert(XmlToSeedFileConverter.java:426)
at edu.iris.dmc.station.converter.XmlToSeedFileConverter.convert(XmlToSeedFileConverter.java:70)
at edu.iris.dmc.station.Application.convert(Application.java:189)
at edu.iris.dmc.station.Application.run(Application.java:127)
at edu.iris.dmc.station.Application.main(Application.java:70)
edu.iris.dmc.station.mapper.MetadataConverterException: java.lang.NumberFormatException: Couldn't format number!-150.1 -150.1 [5 6 ]
at edu.iris.dmc.station.converter.XmlToSeedDocumentConverter.convert(XmlToSeedDocumentConverter.java:329)
at edu.iris.dmc.station.converter.XmlToSeedDocumentConverter.convert(XmlToSeedDocumentConverter.java:48)
at edu.iris.dmc.station.converter.XmlToSeedFileConverter.convert(XmlToSeedFileConverter.java:426)
at edu.iris.dmc.station.converter.XmlToSeedFileConverter.convert(XmlToSeedFileConverter.java:70)
at edu.iris.dmc.station.Application.convert(Application.java:189)
at edu.iris.dmc.station.Application.run(Application.java:127)
at edu.iris.dmc.station.Application.main(Application.java:70)
Caused by: java.lang.NumberFormatException: Couldn't format number!-150.1 -150.1 [5 6 ]
at edu.iris.dmc.io.SeedStringBuilder.appendLocalDepth(SeedStringBuilder.java:204)
at edu.iris.dmc.seed.control.station.B052.toSeedString(B052.java:296)
at edu.iris.dmc.seed.AbstractBlockette.getSize(AbstractBlockette.java:72)
at edu.iris.dmc.seed.Volume.add(Volume.java:266)
at edu.iris.dmc.station.converter.XmlToSeedDocumentConverter.convert(XmlToSeedDocumentConverter.java:112)

[timronan]

-150.1 used as a a local depth value, -150.1, is too long to be formatted in dataless seed. The SEED manual states that Blockette 52 Field 13 can only have a length of 5 characters and this value is a length of 6. The conversion cannot occur because the output dataless would be off by 1 byte which would create a corrupt output dataless file.

The stationmaster-seed-converter is working as expected in this case. The stationxml is not incorrect but it is incompatible with dataless SEED conversions. If this file needs to be converted consider removing the '-' or '.1' from -150.1.

In general, the converter cannot convert from stationxml fields to dataless that have values which do not fit in the dataless predefined byte count. Refer to the SEED manual when looking at specific fields.

[yazan-iris]

The converter should take care of this.

[chad-earthscope]

I'm not sure what a negative value for a depth means at this scale, is the sensor on a 150.1m tower?

This field is "The depth of the sensor under the local surface ground level, in positive meters." Negative is allowed if defining something above the surface (on a pier, platform, etc.), but it's rarely used for that because it's usually not at all important for whatever is being recorded.

[yazan-iris]

The error you received is due to invalid input value (- 150), it is not because the number is too long even though the message states so. A more appropriate exception should be thrown. The Seed manual has this for description:
B052: 13 Local depth (m) D 5 “###.#”

I will leave this open so we fix the exception description.

[yazan-iris]

Seed does not allow negative numbers for depth.

[timronan]

That's true, it seems like we should fix the exception rather than the metadata. The converter should make minimal metadata alterations. Users should fix the data after the exception is thrown.

[chad-earthscope]

Seed does not allow negative numbers for depth.

I agree, that that is best interpretation based on the field pattern. Unfortunately, the text description mentions negative numbers, so there is a conflict in the spec. The wording mentions 'elevations' but the values were adjusted a bit, clearly wasn't very thoroughly edited. So who knows what the consensus intention was.

[timronan]

@chad-iris it is true that the SEED manual is contradictory and that is why I was initially confused about whether the length or the negative sign caused this exception. I just replaced <Depth>-150.1</Depth> with <Depth>-150</Depth> and received the error below. So we know it is not a length issue. Maybe we should strip negative sign on depth when converting from StationXML to SEED. @chad-iris is correct that a negative depth is confusing and should maybe reported as an elevation or is a data error. Stripping the negative sign could change the position that the data creator intended to use.

java.lang.NumberFormatException: Couldn't format number!-150.0 -150.0 [5 6 ]
at edu.iris.dmc.io.SeedStringBuilder.appendLocalDepth(SeedStringBuilder.java:204)
at edu.iris.dmc.seed.control.station.B052.toSeedString(B052.java:296)
at edu.iris.dmc.seed.AbstractBlockette.getSize(AbstractBlockette.java:72)
at edu.iris.dmc.seed.Volume.add(Volume.java:266)
at edu.iris.dmc.station.converter.XmlToSeedDocumentConverter.convert(XmlToSeedDocumentConverter.java:112)
at edu.iris.dmc.station.converter.XmlToSeedDocumentConverter.convert(XmlToSeedDocumentConverter.java:48)
at edu.iris.dmc.station.converter.XmlToSeedFileConverter.convert(XmlToSeedFileConverter.java:426)
at edu.iris.dmc.station.converter.XmlToSeedFileConverter.convert(XmlToSeedFileConverter.java:70)
at edu.iris.dmc.station.Application.convert(Application.java:189)
at edu.iris.dmc.station.Application.run(Application.java:127)
at edu.iris.dmc.station.Application.main(Application.java:70)
edu.iris.dmc.station.mapper.MetadataConverterException: java.lang.NumberFormatException: Couldn't format number!-150.0 -150.0 [5 6 ]
at edu.iris.dmc.station.converter.XmlToSeedDocumentConverter.convert(XmlToSeedDocumentConverter.java:329)
at edu.iris.dmc.station.converter.XmlToSeedDocumentConverter.convert(XmlToSeedDocumentConverter.java:48)
at edu.iris.dmc.station.converter.XmlToSeedFileConverter.convert(XmlToSeedFileConverter.java:426)
at edu.iris.dmc.station.converter.XmlToSeedFileConverter.convert(XmlToSeedFileConverter.java:70)
at edu.iris.dmc.station.Application.convert(Application.java:189)
at edu.iris.dmc.station.Application.run(Application.java:127)
at edu.iris.dmc.station.Application.main(Application.java:70)
Caused by: java.lang.NumberFormatException: Couldn't format number!-150.0 -150.0 [5 6 ]
at edu.iris.dmc.io.SeedStringBuilder.appendLocalDepth(SeedStringBuilder.java:204)
at edu.iris.dmc.seed.control.station.B052.toSeedString(B052.java:296)
at edu.iris.dmc.seed.AbstractBlockette.getSize(AbstractBlockette.java:72)
at edu.iris.dmc.seed.Volume.add(Volume.java:266)
at edu.iris.dmc.station.converter.XmlToSeedDocumentConverter.convert(XmlToSeedDocumentConverter.java:112)
... 6 more
[2020-07-29 12:31:24] [SEVERE] edu.iris.dmc.station.Application run: edu.iris.dmc.station.Application.exitWithError(Application.java:204)
edu.iris.dmc.station.Application.convert(Application.java:194)
edu.iris.dmc.station.Application.run(Application.java:127)
edu.iris.dmc.station.Application.main(Application.java:70)

[yazan-iris]

That's true, it seems like we should fix the exception rather than the metadata. The converter should make minimal metadata alterations. Users should fix the data after the exception is thrown.

Don't mean to drag this further but we do truncate numbers/text to fit Seed required field lengths, I believe its a good practice. It is not the case here though. This is about Seed not accepting negative numbers, the user should fix the number and we should log a better message. if(depth<0)throw new SeedException("B052: Field:13 Local depth cannot be negative");

[yazan-iris]

We do not however change number signs, throwing a better exception is the way to go (I think).

[chad-earthscope]

I agree with @yazan-iris, the converter should not be changing the sign of values. Certainly when it's not a clear violation of StationXML and SEED, which is not the case currently.