Support input in python#21
Conversation
hadisfr
force-pushed
the
support-input-python
branch
from
200d7ea to
93c0782
Compare
|
Sorry, for not looking at this and other PRs sooner, I somewhat missed them. However, if it's not a problem I'd suggest also adding some tests for the new PR functionality. |
| return Const('"{}"'.format(node.s), line=node.lineno) | ||
|
|
||
| def visit_NameConstant(self, node): | ||
| return Const('"{}"'.format(node.s), line=node.lineno) |
There was a problem hiding this comment.
Won't this create a string constant?
There was a problem hiding this comment.
Let me check later. Maybe it should return a boolean value instead of string. 🤔
There was a problem hiding this comment.
I think that NameConstant can be: "True", "False" or "None". So, I think that node.s should be passed to Const as a first argument instead of '"{}"'.format(node.s). However, I would add the very minimal tests to check this.
OK. I'll try to add some tests only for |
2 participants
add support of
input()and some built-in functions to python interpreter and make it possible to get data fromstdinin python