Add DSM501A driver - #243
Open
fedirky wants to merge 1 commit into
Open
Conversation
ulno
requested changes
May 31, 2026
ulno
left a comment
ulno
left a comment
Contributor
There was a problem hiding this comment.
the interrupt implications are not clear, need to be discussed and at least much better documented, why needed and how they will be impacting the whoel system
|
|
||
| // Important to include Functional Interrupt as else it does not allow to | ||
| // define a class-based (object specific) interrupt. | ||
| #include <FunctionalInterrupt.h> |
Contributor
There was a problem hiding this comment.
Ah, that looks dangerous - need to do some serious testing if that doesn't create regression with the led strips (also interrupt critical) - should maybe be made a more global concept? Need to know more before allowing the merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new DSM501A dust sensor driver with two output channels (
pm1andpm25), full IoTempower integration, command documentation, and a compile-test entry. The driver measures both sensor outputs over a 30-second sampling window and publishes both channels separately.