Fix MQTT TLS certificate generation and TLS-only broker behavior - #230
Open
maakler wants to merge 3 commits into
Open
Fix MQTT TLS certificate generation and TLS-only broker behavior#230maakler wants to merge 3 commits into
maakler wants to merge 3 commits into
Conversation
Author
|
Follow-up fix: iot_env previously printed only already-exported IOTEMPOWER variables, so values loaded from system.conf were lost when helper commands sourced iot_env output. This made TLS-mode helpers fall back to defaults unless users exported the variables manually. The update preserves loaded IOTEMPOWER* config values and was checked against TLS tests, non-TLS mode, install tests, and compile smoketest. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes MQTT TLS behavior for IoTempower systems using
IOTEMPOWER_MQTT_USE_TLS=1.Changes
8883only.1883from the included broker when TLS mode is enabled.mqtt_send,mqtt_listen,mqtt_action, andget_ipsuse8883plus the configured CA file in TLS mode.Validation
bash -non changed shell scripts: passed.git diff --check: passed.pytest -q tests/test_mqtt_tls_cert_generation.py tests/test_mqtt_tls_only_mode.py: 5 passed.deploy compileforwemos_d1_mini: passed.8883worked.1883failed as expected.