Enable serde feature for ipnetwork dependency#113
Merged
Conversation
durable-runtime derives serde::Serialize/Deserialize on an enum containing ipnetwork::IpNetwork, but declared ipnetwork without the serde feature. This compiled in durable's own workspace only because another member enabled ipnetwork/serde via feature unification. Downstream consumers without that feature active got a compile error. Enable the serde feature directly so durable-runtime no longer relies on a dependent to activate it. Fixes #112
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable the
serdefeature for theipnetworkcrate to support serialization and deserialization of network types.Changes
ipnetworkdependency to explicitly enable theserdefeature, allowing network types to be serialized and deserializedDetails
This change enables serialization support for IP network types used throughout the durable-runtime crate, which is necessary for any code that needs to serialize network configuration or data structures containing IP network information.
https://claude.ai/code/session_01WbWc3V1fbNfmjAvfGcrpkg