fix(ci): trigger tag-release on merge commits, not just squash merges#6
Closed
thinkingfish wants to merge 2 commits into
Closed
fix(ci): trigger tag-release on merge commits, not just squash merges#6thinkingfish wants to merge 2 commits into
thinkingfish wants to merge 2 commits into
Conversation
The job guard used startsWith(head_commit.message, 'release: v'), which only matches squash-merge commit messages. A default merge commit starts with 'Merge pull request #N ...' and carries the PR title on a later line, so the guard evaluated false and the release was skipped (no tag, no publish). Use contains() so both merge strategies trigger the job; dev version-bump commits don't contain 'release: v' and remain unaffected. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VR4FAfMXbCq7k6jQUGWa1w
Add CLAUDE.md explaining why release PRs must be squash-merged: the tag-release.yml workflow checks for 'release: v' in the merge commit message, which only works with squash merges (default merge commits have 'Merge pull request ...' at the start). Update release skill to emphasize squash-merge requirement and reference CLAUDE.md for details. Includes recovery steps for accidental merge commits. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VR4FAfMXbCq7k6jQUGWa1w
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The v1.0.1 release (PR #5) was merged but never tagged or published, because the
tag-release.ymljob was skipped.Root cause
The job guard was:
startsWithonly matches squash-merge commit messages (release: v1.0.1 (#5)). PR #5 was merged with a default merge commit, whose message is:That starts with
Merge pull request..., so the guard evaluated false and the job was skipped (run #21, conclusionskipped, 2s, no steps). No tag →release.yml(triggered on tag push) never ran → no crates.io publish, no GitHub Release, no dev-version bump.Fix
Use
contains(...)instead ofstartsWith(...)so both merge strategies trigger the job:release: v1.0.1 (#5)✅...\n\nrelease: v1.0.1✅Dev version-bump commits (
chore: bump ...) don't containrelease: v, so they remain unaffected.🤖 Generated with Claude Code
Generated by Claude Code