chore(status-bar): add SuppressWarnings annotation to StatusBar plugin (Android) - #2438
Conversation
|
Released dev build of status-bar with dev version: 8.0.0-dev-2438-20251112T093311.0 |
jcesarmobile
left a comment
There was a problem hiding this comment.
Instead of annotating the whole methods, can the deprecated calls me moved to new separate private methods and only suppress the new ones with the deprecated code?
Annotating the whole methods can cause that we miss future deprecations.
425eef1 to
f6ca182
Compare
f6ca182 to
9eeac8b
Compare
jcesarmobile
left a comment
There was a problem hiding this comment.
I only meant to move the the deprecated code for the new deprecations, the old ones are on methods that no longer work on Android 15+, so there is no need. But since you did it, we can keep it that way.
activity is available in all the plugin, so you can call activity.getWindow() from inside the methods when you need the window instead of passing the window to methods such as getStatusBarColorDeprecated
9eeac8b to
37a13d0
Compare
|
Will adding the Both: and |
@crossan007 doubt it will, the source code is still there, and Google Play will probably still inform you of that. Android 15 and 16 apps are edge to edge, regardless of the StatusBar Plugin using these APIs (that may not have effect on Android 15+, but still do when your app is running on lower Android versions). For some better control of your edge-to-edge application, refer to the SystemBars API introduced in Capacitor 8, part of Hope this helps! |
No description provided.