fix(a11y): increase sm and icon button touch targets to 44x44px (#243) - #342
Open
arpita-1111 wants to merge 1 commit into
Open
fix(a11y): increase sm and icon button touch targets to 44x44px (#243)#342arpita-1111 wants to merge 1 commit into
arpita-1111 wants to merge 1 commit into
Conversation
|
🎉 Thank you @arpita-1111 for submitting a Pull Request! We're excited to review your contribution. ✅ Before Review
⚡ Want faster reviews and contributor support? Join our Discord community: 🔗 https://discord.gg/FcXuyw2Rs Maintainers and mentors are active there and can help resolve blockers quickly. Happy Contributing! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Closes #243
What this PR does
Increases the touch target size of the
smandiconbutton variants to meet WCAG 2.2 Success Criterion 2.5.8 (Target Size - Minimum). Previously these variants were smaller than the recommended 44x44 CSS pixels, making them harder to interact with on touch-enabled devices.Type of change
Stack affected
Changes
Frontend
frontend/src/app/components/ui/button.tsx.smvariant height fromh-8(32px) toh-11(44px).iconvariant size fromsize-9(36px) tosize-11(44px).Testing
How did you test this?
npm run dev.Checklist
Anything reviewers should focus on
Please confirm the
smandiconbutton variants render correctly across different pages (sidebar, toolbar, dashboard) and that no layouts break due to the increased touch target size.Screenshots (if UI changed)
Sidebar navigation buttons (Dashboard, Findings, Fixes, Verify, Leaderboard) and Light mode toggle now render at increased touch target size, confirmed visually in local dev environment.