fix(ci): refuse to attach OSSign artifacts that don't match the release tag - #144
Merged
Conversation
…se tag The OSSign single_check action exposes no success/failure signal, and when the polled signing run has failed it returns the previous successful run's artifacts. This let a failed v1.8.2-rc.1 signing run silently attach June's 1.8.1 test build to the draft release. Verify the version in the returned latest.yml against the target ref before attaching, and fail loudly on mismatch or missing metadata. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
During the v1.8.2-rc.1 release, the OSSign-side Windows build failed (node-gyp cannot detect VS on the current
windows-latestimage — same issue we pinned away in 270c5b2, but in the OSSign-hosted workflow). Despite the failure, the wait loop attached Windows artifacts to the draft release — June's 1.8.1 test build.Root cause:
ossign/actions/workflow/dispatchwithsingle_checkhas no success/failure output, and for a failed run it returns the project's previous successful artifacts.wait-signature.ymlgated attachment only onsigned_artifacts != '', so stale wrong-version binaries were silently attached.Fix
Add a verification step before attaching: parse
version:from the returnedlatest.ymland require it to equal the target tag (sansv). Fail loudly on mismatch or if nolatest.ymlis present.The OSSign-side runner pin (
windows-latest→windows-2022inOSSign/invoke-ai-launcher) is handled separately — this PR is the defense-in-depth so a recurrence can never corrupt a release again.🤖 Generated with Claude Code