fix(android): allow older Kotlin compilers with ads SDK 25.4 - #866
fix(android): allow older Kotlin compilers with ads SDK 25.4#866floze-the-genius wants to merge 2 commits into
Conversation
|
|
481b12c to
fa05a06
Compare
….3.0, docs - Pin example KOTLIN_VERSION to 2.1.0 so Ads 25.4 metadata path is exercised - Gate -Xskip-metadata-version-check to Kotlin compilers older than 2.3 - Document Android Kotlin 2.1 / Ads 25.3+ compatibility options in index docs
mikehardy
left a comment
There was a problem hiding this comment.
thanks @floze-the-genius! clever fix for a problem that's sure to hit most folks at the moment. I added a quick follow-up and I'll be happy to merge if you can sign the CLA, thanks!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #866 +/- ##
==========================================
- Coverage 43.72% 39.35% -4.37%
==========================================
Files 30 36 +6
Lines 549 671 +122
Branches 151 172 +21
==========================================
+ Hits 240 264 +24
- Misses 309 407 +98 🚀 New features to boost your workflow:
|
|
there is no problem merging this despite iOS build failing - it's failing for unrelated reasons still need a CLA sign from @floze-the-genius though, otherwise we'll have to recreate this PR separately... |
Description
Google Mobile Ads 25.3+ embeds Kotlin 2.3 metadata even though this module only consumes its public Java API. That makes the library fail to compile in Expo and React Native projects still using Kotlin 2.1.x.
Configure only this library's
KotlinCompiletasks to skip the dependency metadata version check. This preserves the AndroidAgeRestrictedTreatmentAPI added with the newer SDK without forcing every consumer module to upgrade to Kotlin 2.3.Related issues
Fixes #863
Release Summary
Allow Android projects using Kotlin 2.1.x to compile with Google Mobile Ads SDK 25.4.0.
Checklist
AndroidiOSe2etests added or updated in__tests__e2e__jesttests added or updated in__tests__Test Plan
play-services-ads:25.4.0AAR classes.-Xskip-metadata-version-checkconfiguration in Groovy.yarn tests:jest --runInBand(7 suites passed, 79 tests passed)yarn tsc:compileyarn lintA full Android example assemble was not run locally because this machine has no accepted Android SDK installation; the repository Android CI remains the end-to-end build check.
🔥