Skip to content

fix(pnpm): add prop-types as peer dependency#342

Merged
Samk13 merged 2 commits into
inveniosoftware:masterfrom
Samk13:fix-pnpm-install
Jul 2, 2026
Merged

fix(pnpm): add prop-types as peer dependency#342
Samk13 merged 2 commits into
inveniosoftware:masterfrom
Samk13:fix-pnpm-install

Conversation

@Samk13

@Samk13 Samk13 commented Jun 29, 2026

Copy link
Copy Markdown
Member

❤️ Thank you for your contribution!

Description

  • fix pnpm installation Unresolved dependencies error: src/lib/index.js → dist/cjs/index.js, dist/esm/index.js... (!) Unresolved dependencies https://rollupjs.org/guide/en/#warning-treating-module-as-external-dependency prop-types (imported by src/lib/forms/fieldComponents.js)

  • add pnpm-workspace as after pnpm 11 its required to declare if the postscript should run.

  • add node 24 to CI matrix

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

* fix pnpm installation Unresolved dependencies error:
src/lib/index.js → dist/cjs/index.js, dist/esm/index.js...
(!) Unresolved dependencies
https://rollupjs.org/guide/en/#warning-treating-module-as-external-dependency
prop-types (imported by src/lib/forms/fieldComponents.js)

* add pnpm-workspace as after pnpm 11 its required to declare
  if the postscript should run.
@Samk13 Samk13 force-pushed the fix-pnpm-install branch from 13fb92b to 95ce2de Compare June 29, 2026 14:00
@Samk13 Samk13 force-pushed the fix-pnpm-install branch from b864572 to a68ec72 Compare June 29, 2026 14:02
@Samk13 Samk13 changed the title fix(pnpm): add prop-types as dependency fix(pnpm): add prop-types as peer dependency Jun 29, 2026
@Samk13 Samk13 merged commit 1fdef31 into inveniosoftware:master Jul 2, 2026
3 checks passed
@Samk13 Samk13 deleted the fix-pnpm-install branch July 2, 2026 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants