Fix WS agent termination after graceful stop#492
Draft
Zakaria-Kofiro wants to merge 3 commits into
Draft
Conversation
Zakaria-Kofiro
force-pushed
the
ws-terminate-agent-fix
branch
from
2d00aea to
4e3a179
Compare
Zakaria-Kofiro
changed the title
…d lifecycle handler so STOP completion schedules VM termination without requiring a request-scoped controller bean
Schedule VM termination when the controller-initiated WebSocket path receives terminal agent status so STOP drains still clean up EC2 instances. Wire the existing VMTerminator into the WS client and cover terminal, duplicate, and reconnect status handling. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VMTrackerwhile preventing terminal statuses from silently bypassing termination.Notes
instanceId.jobIdremains sourced from the agent status payload, matching the existing HTTP path; binding it to the WS session can be handled as a follow-up hardening task.Please make sure these check boxes are checked before submitting
mvn clean test -P default** PR review process **