Repository navigation
[benchmarker] Add options to control implicit SCD subscription creation during operational intent updates - #1859
Merged
Merged
Conversation
…on during operational intent updates
BenjaminPelletier
approved these changes
Oct 28, 2026
Co-authored-by: Benjamin Pelletier <BenjaminPelletier@users.noreply.github.com>
Co-authored-by: Benjamin Pelletier <BenjaminPelletier@users.noreply.github.com>
the-glu
commented
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two options in the benchmarker for implicit subscriptions to fix #1845:
reuse_subscriptionto reuse subscriptionscreate_when_activatedto request an implicit subscription only when going to the activated state.Tested locally with
minimal.jsonnet.Parsing the report with
jq -r '.report.scenarios[].operations[] | select(.type|test("(create|update)OperationalIntentReference")) | .origins[] | select(.origin|startswith("Implicit")) | .outcomes[].successful[]? | .query.request.json | "\(.state) subscription_id=\(.subscription_id != null) new_subscription=\(.new_subscription != null)"' /tmp/report | sort | uniqUsing default values:
Enabling
reuse_subscription:Enabling
create_when_activated:Enabling both AND manually generating two activate actions (to have an ID to reuse):
The latter enables the requested behavior in #1845.