Repository navigation
[uss_qualifier] Improve generic parameters of ResourceProvidingResource - #1809
Draft
BenjaminPelletier wants to merge 1 commit into
Draft
BenjaminPelletier wants to merge 1 commit into
BenjaminPelletier wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, ResourceProvidingResource accepts a SpecificationType generic parameter because I thought that was necessary to satisfy Python typing requirements. However, the obvious way to use ResourceProvidingResources would be to specify just the type of resource they produce as a generic parameter, especially in test suite declarations. This PR makes that generic type parameter adjustment and uses this to improve the type annotations on test suite declarations, allowing removal of the extra comments previously needed to explain this expectation.