Repository navigation
[uss_qualifier] Add SingularResource and use for conflicting_flights - #1808
Open
BenjaminPelletier wants to merge 1 commit into
Open
BenjaminPelletier wants to merge 1 commit into
BenjaminPelletier wants to merge 1 commit into
Conversation
BenjaminPelletier
marked this pull request as ready for review
October 15, 2026 02:07
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we're providing both a singular conflicting_flights resource and a conflicting_flights_provider (capable of providing any number of variants of conflicting_flights), and that is unnecessarily duplicative/redundant. This PR slightly alters the way that resources populate into the pool to enable a generic SingularResource which accepts a provider and presents as a single resource instance drawn from that provider. This makes it possible for test configurations to skip providing conflicting_flights, instead relying on conflicting_flights_provider. But, this is made non-breaking by optionally accepting conflicting_flights to override the automatic usage of conflicting_flights_provider.
Also, a small type schema enumeration bug is fixed.