Repository navigation
[benchmarker] Add horizontal zoom to timeline - #1804
Merged
Merged
Conversation
BenjaminPelletier
approved these changes
Oct 15, 2026
BenjaminPelletier
left a comment
BenjaminPelletier
left a comment
Member
There was a problem hiding this comment.
I have no concerns with this and I'd like to build something on top of it, so LGTM conditional on your evaluation of the report output looking and behaving as desired.
| <div id="tooltip"></div> | ||
| <div class="help-hint"> | ||
| <strong>Controls:</strong> Left-drag or Mouse wheel to scroll • Shift + Left-drag or Shift + Wheel to zoom • Hover Time column to inspect active operations | ||
| <strong>Controls:</strong> Left-drag or Mouse wheel to scroll • Shift + Left-drag or Shift + Wheel to zoom time • Ctrl/Alt + Wheel or pinch to zoom lanes • Horizontal wheel or bottom bar to scroll lanes • Hover Time column to inspect active operations |
Member
There was a problem hiding this comment.
Seems like reasonable UX though I didn't even know a horizontal wheel was a standard piece of equipment :)
Contributor
Author
|
Output looking is good and works as expected in terms of interactions. (Tested with trackpad) |
barroco
marked this pull request as ready for review
October 16, 2026 21:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to zoom horizontally on the timeline scenario of the benchmarker.
Screenshot of the resulting horizontal zoom: