Skip to content

[_]: fix/cancellation trial security issue#386

Merged
sg-gs merged 1 commit into
masterfrom
fix/cancellation-trial-security-issue
Jul 9, 2026
Merged

[_]: fix/cancellation trial security issue#386
sg-gs merged 1 commit into
masterfrom
fix/cancellation-trial-security-issue

Conversation

@xabg2

@xabg2 xabg2 commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Avoid passing the subscription ID in the request body, as this could allow a user to cancel a subscription they do not own. Instead, retrieve the authenticated user's active subscription using the user authentication token, and use that subscription for the cancellation request.

@xabg2 xabg2 requested review from jzunigax2 and sg-gs as code owners July 8, 2026 14:16
@xabg2 xabg2 self-assigned this Jul 8, 2026
@xabg2 xabg2 added the bug Something isn't working label Jul 8, 2026
@sonarqubecloud

sonarqubecloud Bot commented Jul 8, 2026

Copy link
Copy Markdown

sg-gs
sg-gs previously approved these changes Jul 8, 2026
Base automatically changed from feature/cancellation-flow-for-users-outside-refund-period to master July 9, 2026 08:12
@xabg2 xabg2 dismissed sg-gs’s stale review July 9, 2026 08:12

The base branch was changed.

@xabg2 xabg2 requested a review from sg-gs July 9, 2026 08:12
@sg-gs sg-gs merged commit 4486ab6 into master Jul 9, 2026
8 of 9 checks passed
@sg-gs sg-gs deleted the fix/cancellation-trial-security-issue branch July 9, 2026 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ready-for-preview

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants