[BR-2114]: iOS generation + add list-view thumbnails#524
Open
terrerox wants to merge 3 commits into
Open
Conversation
toFileUri produced file://<host>/... from a relative path, so iOS CreateThumbnail failed with Code=1 "Could not create image source from URL". Prepend a leading slash when missing so the URI is always an absolute file:///... path.
terrerox
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
toFileUrinow emits absolutefile:///…URIs. A relative pathbecame
file://var/…(parsed as host), so iOS thumbnail generation failed withCreateThumbnail Code=1and uploads showed no preview.only), via a shared
useDownloadedThumbnailhook used by both grid and list.Falls back to the type icon for non-images/folders/download errors.