[PB-5921]: File Provider folder browsing (read-only enumeration)#492
Merged
terrerox merged 3 commits intoJul 8, 2026
Merged
Conversation
The File Provider extension needs the Drive API base URL to build authenticated requests from the App Group keychain. Add a dedicated shared key so it can be read alongside the existing auth token.
Replace the placeholder enumerator with real Drive folder browsing: paginate folders then files for a container, build FileProviderItem metadata (name, type, size, dates, capabilities) from Drive responses, and resolve identifiers via a typed folder/file id codec. Add a DriveAPIFactory that constructs an authenticated DriveAPI from the shared App Group keychain, and wire the new sources into the extension target.
terrerox
force-pushed
the
feature/pb-5920-file-provider-folder-browsing
branch
from
4fcdcfd to
f222339
Compare
terrerox
changed the title
patricioxavier8
approved these changes
Jun 12, 2026
Base automatically changed from
feature/pb-5920-file-provider-domain-registration
to
release-1.9.1
June 19, 2026 05:06
CandelR
reviewed
Jul 3, 2026
Comment on lines
+178
to
+191
| private static let iso8601Formatter: ISO8601DateFormatter = { | ||
| let formatter = ISO8601DateFormatter() | ||
| formatter.formatOptions = [.withInternetDateTime, .withFractionalSeconds] | ||
| return formatter | ||
| }() | ||
|
|
||
| private static func parseISO8601(_ value: String?) -> Date? { | ||
| guard let value = value, !value.isEmpty else { return nil } | ||
| if let date = iso8601Formatter.date(from: value) { | ||
| return date | ||
| } | ||
| let fallback = ISO8601DateFormatter() | ||
| fallback.formatOptions = [.withInternetDateTime] | ||
| return fallback.date(from: value) |
Contributor
There was a problem hiding this comment.
I think that fallback creates a new ISO8601DateFormatter on every call, and this is executed for each item in the enumeration. Cache it as a static let, just like iso8601Formatter above, do not mutate an instance shared between the two formats because it is called from concurrent Task {} in the enumerator.
Also, I would rename parseISO8601 to parseDate
|
CandelR
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements read-only browsing of Drive in the iOS Files.app via the
InternxtFileProviderextension.What this delivers
and navigates into subfolders.
plainName+ extension.NSFileProviderPageas the cursor(folders first, then files,
plainName ASC), so large folders show all items.materialization flags so items render as normal cloud items (folders
materialized; files cloud-downloadable) instead of greyed/locked placeholders.
notAuthenticated(drives the system "Sign in to Internxt Drive" prompt); network errors
surface as errors without crashing.
DriveAPIFactorybuilds an authenticated client fromthe shared App Group keychain; adds a shared
driveBaseUrlkey.f:/d:) so a container identifierround-tripped by Files.app resolves back to a Drive folder uuid.