deps: pin pepc and stats-collect to their GitHub release URLs#25
Open
x4v13r64 wants to merge 1 commit into
Open
deps: pin pepc and stats-collect to their GitHub release URLs#25x4v13r64 wants to merge 1 commit into
x4v13r64 wants to merge 1 commit into
Conversation
The pyproject currently declares pepc and stats-collect as version-floor PyPI requirements (`pepc>=2.0.1`, `stats-collect>=1.0.68`). Per the install guide at docs/guide-install.md, both are distributed via GitHub (`intel/pepc`, `intel/stats-collect`) and must be installed into the same venv before wult for the deps to resolve cleanly. That ordering is easy to miss when somebody copy-pastes the standalone `pip3 install git+...wult.git@release` example from the install guide into a fresh venv, or runs it from a script that didn't pre-install both upstream tools. Switching the deps to PEP 440 direct URL references makes the install order-independent: `pip install git+...wult.git@release` pulls pepc and stats-collect from the upstream repositories regardless of whether they were pre-installed. The `@release` tag is the same one the install guide already uses for each, so the version pin behaviour is unchanged. If a future PyPI publish of either name happens, the lines can be flipped back to regular version ranges without further effort.
dedekind
requested changes
Jun 9, 2026
| "pepc>=2.0.1", | ||
| "stats-collect>=1.0.68", | ||
| "pepc @ git+https://github.com/intel/pepc.git@release", | ||
| "stats-collect @ git+https://github.com/intel/stats-collect.git@release", |
Contributor
There was a problem hiding this comment.
Yes, good idea, thanks you! Need to adjust the make_a_release script though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pyproject currently declares
pepcandstats-collectas version-floor PyPI requirements (pepc>=2.0.1,stats-collect>=1.0.68). Per the install guide atdocs/guide-install.md, both are distributed via GitHub (intel/pepc,intel/stats-collect) and must be installed into the same venv beforewultfor the deps to resolve cleanly. That ordering is easy to miss when somebody copy-pastes the standalonepip3 install git+...wult.git@releaseexample from the install guide into a fresh venv, or runs it from a script that didn't pre-install both upstream tools.Switching the deps to PEP 440 direct URL references makes the install order-independent:
pip install git+...wult.git@releasepullspepcandstats-collectfrom the upstream repositories regardless of whether they were pre-installed. The@releasetag is the same one the install guide already uses for each, so the version pin behaviour is unchanged.If either name ever gets published to PyPI, these lines can be flipped back to regular version ranges without further effort.