Safestring include toupper header#35
Open
divneil wants to merge 2 commits into
Open
Conversation
o While compiling for non-Linux based platforms where errno.h is not available, a new compile time flag is included. o Defining __LOCAL_ERRNO__ allows the safestring to compile without looking for errno.h Signed-off-by: Divneil Rai Wadhawan <divneil.r.wadhawan@intel.com>
o toupper() suggests to include <ctype.h> as the header file for its declaration. So, added the same. Signed-off-by: Divneil Rai Wadhawan <divneil.r.wadhawan@intel.com>
|
The PR header does not match the actual changes made, which adds |
Author
Actually, I pushed the new patch over the top of the previous patch, so, github is showing like that. Once #34 is merged and with a rebase, #35 will only show 1 commit. Please let me know if its okay, otherwise, I will push a new patch over master. |
ausyskin
reviewed
Mar 20, 2025
| #include "safe_str_constraint.h" | ||
| #include "safe_str_lib.h" | ||
|
|
||
| #include <ctype.h> |
Contributor
There was a problem hiding this comment.
safeclib_private.h has it defined, can you re-check? Or you missed STDC_HEADERS somehow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.