fix(esimd): declare INT4 output mutations#537
Open
gc-fu wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
These kernels write their output arguments in place, but their schemas previously declared every tensor immutable.
torch.compilefunctionalization could therefore treat the calls as pure, reorder them, or eliminate them when the aliased return was unused.The affected ops are:
esimd_gemv_int4esimd_gemv_int4_fused2esimd_resadd_norm_gemv_int4_pertesimd_norm_gemv_int4_pertValidation
custom-esimd-kernels-vllmwheel for BMGtorch.library.opchecktest_schemaafter the changetest_faketensorwith matching downstream fake implementationstorch.compileINT4 GEMV smoke test is bitwise equal to eagerPerformance impact
The device kernels, launch geometry, tensor shapes, and arithmetic are unchanged. Eager execution only goes through a void C++ wrapper that discards the existing aliased return. No measurable eager performance impact is expected. Compile mode may retain the dependency/copy-back operations required by the declared mutations; those are necessary for correctness.