Fix/gdn conv seq fp32 state#500
Draft
liu-shaojun wants to merge 1 commit into
Draft
Conversation
v0.21.0 sets mamba_ssm_dtype="float32" (from HF config), so ssm_state is float32 instead of fp16. The kernel was reading/writing it as fp16, producing silent data corruption (all-zero state writes, NaN output). Fix: change ssm_state_ptr from fp16* to float* in gdn_conv_fused_seq.h and the binding in esimd_kernel_lgrf.sycl. lsc_load/store helpers now operate on float32 directly (computation was already fp32 internally). The interleaved variant (gdn_conv_fused.h) is NOT changed — it serves FP8 models where ssm_state remains fp16. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.