Add initial draft of claude skill files#1042
Closed
mlim19 wants to merge 2 commits into
Closed
Conversation
Signed-off-by: Min Lim <min.yeol.lim@intel.com>
There was a problem hiding this comment.
Pull request overview
Adds an initial set of Claude skill files under .claude/skills to guide common gProfiler development workflows, including testing, linting, releases, CI, debugging, dependency updates, and profiler development.
Changes:
- Adds workflow-oriented skill docs for PR creation, CI status, linting, testing, debugging, Docker troubleshooting, and releases.
- Adds domain-specific guidance for architecture, ARM support, Java support, heartbeat mode, dependencies, and new profiler implementation.
- Includes TODO sections for future expansion of each skill.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
.claude/skills/architecture/SKILL.md |
Adds architecture overview and key component guidance. |
.claude/skills/arm-support/SKILL.md |
Adds ARM/Aarch64 compatibility and troubleshooting guide. |
.claude/skills/ci-status/SKILL.md |
Adds CI status and workflow troubleshooting commands. |
.claude/skills/debug/SKILL.md |
Adds debugging commands and common profiler issue guidance. |
.claude/skills/dependency-update/SKILL.md |
Adds dependency update and security scanning workflow. |
.claude/skills/docker-troubleshoot/SKILL.md |
Adds Docker build/runtime troubleshooting guide. |
.claude/skills/heartbeat/SKILL.md |
Adds heartbeat system usage and troubleshooting guide. |
.claude/skills/java-support/SKILL.md |
Adds Java/JDK support update guidance. |
.claude/skills/lint/SKILL.md |
Adds linting and code quality command guide. |
.claude/skills/new-profiler/SKILL.md |
Adds guide and examples for adding a new profiler. |
.claude/skills/pr-create/SKILL.md |
Adds pull request creation workflow. |
.claude/skills/review-code/SKILL.md |
Adds code review checklist. |
.claude/skills/test/SKILL.md |
Adds test suite command guide. |
.claude/skills/version-release/SKILL.md |
Adds version bump and release workflow guide. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| --- | ||
| name: test | ||
| description: Run gProfiler test suite. Use when the user wants to run tests, check if tests pass, or test specific functionality. | ||
| allowed-tools: Bash(sudo *) Bash(pytest *) Bash(python3 -m pytest *) Bash(./tests/test.sh *) Bash(cd *) Read |
Comment on lines
+40
to
+51
| /opt/gprofiler/gprofiler \ | ||
| -u \ | ||
| --token=$GPROFILER_TOKEN \ | ||
| --service-name=$GPROFILER_SERVICE \ | ||
| --server-host $GPROFILER_SERVER \ | ||
| --dont-send-logs \ | ||
| --server-upload-timeout 10 \ | ||
| -c \ | ||
| --disable-metrics-collection \ | ||
| --java-safemode= \ | ||
| -d 60 \ | ||
| --java-no-version-check |
Comment on lines
+59
to
+71
| @register_profiler( | ||
| "MyRuntime", | ||
| # Possible profiler names for CLI selection | ||
| possible_modes=["myruntime", "disabled"], | ||
| # Default mode | ||
| default_mode="myruntime", | ||
| # Supported architectures | ||
| supported_archs=["x86_64", "aarch64"], | ||
| # Profiler-specific CLI arguments | ||
| profiler_arguments=[ | ||
| # Add any runtime-specific arguments | ||
| ], | ||
| ) |
Comment on lines
+84
to
+97
| stop_event, | ||
| storage_dir: str, | ||
| profile_spawned_processes: bool, | ||
| *args, | ||
| **kwargs, | ||
| ): | ||
| super().__init__( | ||
| frequency=frequency, | ||
| duration=duration, | ||
| stop_event=stop_event, | ||
| storage_dir=storage_dir, | ||
| profile_spawned_processes=profile_spawned_processes, | ||
| ) | ||
| # Initialize profiler-specific state |
Comment on lines
+126
to
+143
| ### Step 2: Add CLI Arguments | ||
|
|
||
| In `gprofiler/main.py`, add runtime-specific arguments: | ||
|
|
||
| ```python | ||
| # In the argument parser section | ||
| parser.add_argument( | ||
| "--myruntime-mode", | ||
| choices=["myruntime", "disabled"], | ||
| default="myruntime", | ||
| help="MyRuntime profiling mode", | ||
| ) | ||
| parser.add_argument( | ||
| "--no-myruntime", | ||
| action="store_true", | ||
| help="Disable MyRuntime profiling", | ||
| ) | ||
| ``` |
Comment on lines
+50
to
+55
| When a tag is pushed, `.github/workflows/build-test-deploy.yml`: | ||
| 1. Builds executables (x86_64, aarch64) | ||
| 2. Builds Docker containers | ||
| 3. Runs full test suite | ||
| 4. Deploys to Docker Hub (`intel/gprofiler:X.Y.Z`, `intel/gprofiler:latest`) | ||
| 5. Creates GitHub release with executables |
4 tasks
prashantbytesyntax
previously approved these changes
Jun 24, 2026
prashantbytesyntax
left a comment
prashantbytesyntax
left a comment
Contributor
There was a problem hiding this comment.
nit : please add the PR description
) * Add implement-from-spec skill for architecture-aware feature work Teach the agent how to turn a design spec into a minimal gProfiler change by mapping it onto the current architecture, choosing the smallest existing flow to extend, and validating the result locally. The skill adds concrete guidance for command-control changes, repo-native test bootstrap, targeted-vs-broad test selection, and regression-aware review before handoff. Co-authored-by: Cursor <cursoragent@cursor.com> * Improve architecture, heartbeat, review-code, and test skills Bring the draft skills closer to the current gProfiler codebase by teaching the dynamic profiling architecture, fixing stale heartbeat references and required flags, adding architecture-aware code review checks, and documenting a staged local test strategy that reuses the repo's existing harness before broader regression runs. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: prashantbytesyntax <prashantbytesyntax@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots
Checklist: