Skip to content

Feat/wsl2 [DO NOT MERGE] - #358

Open
rishika-y-gaur wants to merge 24 commits into
intel-retail:mainfrom
rishika-y-gaur:feat/wsl2
Open

rishika-y-gaur wants to merge 24 commits into
intel-retail:mainfrom
rishika-y-gaur:feat/wsl2

Conversation

@rishika-y-gaur

@rishika-y-gaur rishika-y-gaur commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

PR Checklist

  • Added label to the Pull Request for easier discoverability and search
  • Commit Message meets guidelines as indicated in the URL https://github.com/intel-retail/loss-prevention/blob/main/CONTRIBUTING.md
  • Every commit is a single defect fix and does not mix feature addition or changes
  • Unit Tests have been added for new changes
  • Updated Documentation as relevant to the changes
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with repository license and clearly outlined the added dependency.
  • PR change contains code related to security
  • PR introduces changes that breaks compatibility with other modules (If YES, please provide details below)

What are you changing?

Issue this PR will close

close: #issue_number

Anything the reviewer should know when reviewing this PR?

Test Instructions if applicable

If the there are associated PRs in other repositories, please link them here (i.e. intel-retail/loss-prevention )

Need performance tools PR merged before merging current PR

LINK:
intel-retail/performance-tools#255

@rishika-y-gaur rishika-y-gaur changed the title Feat/wsl2 Feat/wsl2 [DO NOT MERGE] Sep 24, 2026
@rishika-y-gaur
rishika-y-gaur requested a lite review from Copilot September 24, 2026 03:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Critical Compose configuration issues and additional portability and model-readiness issues remain unresolved.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 2 High severity · 1 Medium severity · 1 Low severity

Open (4)
What changed in this PR

Adds WSL2 GPU support, Windows benchmark integration, configurable rendering, and expanded model handling.

Changes:

  • Adds WSL2 Compose and Makefile integration.
  • Adds setup, benchmark, and hardware-metrics documentation.
  • Improves rendering configuration and FP32 model downloads.
File Summary
src/​run-pipeline.sh Handles missing DRM devices safely.
src/​gst-pipeline-generator.py Adds configurable video sinks and conversion.
src/​docker-compose-wsl2.yml Defines WSL2 devices and library mappings; requires Compose compatibility fixes, correct GPU device replacement, and library paths for lp-pipeline-runner.
README.md Documents WSL2 workflows.
Makefile Adds WSL2 detection and benchmark setup; Windows Python path is not portable (moderate, 4 votes).
download-scripts/​omz-model-download.sh Supports precision-specific model validation.
download-scripts/​model-handler.sh Adds FP32 face-model handling.
download-scripts/​model-downloader.sh Improves readiness checks; JSON metadata can be skipped by the top-level model check (moderate, 1 vote).
docs/​wsl2_setup.md Provides WSL2 setup guidance; verification searches for the wrong video sink (nit, 2 votes).
docs/​wsl2_benchmark.md Documents WSL2 benchmark metrics.
docs/​wsl_hardware_metrics.md Documents hardware-metrics prerequisites.
check_models.sh Adds FP32 model requirements.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines +6 to +7
devices: !reset
- /dev/dxg:/dev/dxg
Comment on lines +6 to +7
devices: !reset
- /dev/dxg:/dev/dxg
Comment thread Makefile
STREAM_LOOP ?= true
WSL2 ?= $(if $(shell uname -r | grep -i microsoft),true,false)
export WSL2
WINDOWS_PYTHON ?= /mnt/c/Users/intel/AppData/Local/Programs/Python/Python311/python.exe
Comment thread docs/wsl2_setup.md
Comment on lines +995 to +997
docker compose -f src/docker-compose-wsl2.yml exec lp-pipeline-runner \
grep -n 'gvawatermark.*videoconvert.*autovideosink' \
/home/pipeline-server/pipelines/pipeline.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants