Feat/wsl2 [DO NOT MERGE] - #358
Open
rishika-y-gaur wants to merge 24 commits into
Open
rishika-y-gaur wants to merge 24 commits into
rishika-y-gaur wants to merge 24 commits into
Conversation
validated till step 10
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Critical Compose configuration issues and additional portability and model-readiness issues remain unresolved.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Open (4)
What changed in this PR
Adds WSL2 GPU support, Windows benchmark integration, configurable rendering, and expanded model handling.
Changes:
- Adds WSL2 Compose and Makefile integration.
- Adds setup, benchmark, and hardware-metrics documentation.
- Improves rendering configuration and FP32 model downloads.
| File | Summary |
|---|---|
src/run-pipeline.sh |
Handles missing DRM devices safely. |
src/gst-pipeline-generator.py |
Adds configurable video sinks and conversion. |
src/docker-compose-wsl2.yml |
Defines WSL2 devices and library mappings; requires Compose compatibility fixes, correct GPU device replacement, and library paths for lp-pipeline-runner. |
README.md |
Documents WSL2 workflows. |
Makefile |
Adds WSL2 detection and benchmark setup; Windows Python path is not portable (moderate, 4 votes). |
download-scripts/omz-model-download.sh |
Supports precision-specific model validation. |
download-scripts/model-handler.sh |
Adds FP32 face-model handling. |
download-scripts/model-downloader.sh |
Improves readiness checks; JSON metadata can be skipped by the top-level model check (moderate, 1 vote). |
docs/wsl2_setup.md |
Provides WSL2 setup guidance; verification searches for the wrong video sink (nit, 2 votes). |
docs/wsl2_benchmark.md |
Documents WSL2 benchmark metrics. |
docs/wsl_hardware_metrics.md |
Documents hardware-metrics prerequisites. |
check_models.sh |
Adds FP32 model requirements. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+6
to
+7
| devices: !reset | ||
| - /dev/dxg:/dev/dxg |
Comment on lines
+6
to
+7
| devices: !reset | ||
| - /dev/dxg:/dev/dxg |
| STREAM_LOOP ?= true | ||
| WSL2 ?= $(if $(shell uname -r | grep -i microsoft),true,false) | ||
| export WSL2 | ||
| WINDOWS_PYTHON ?= /mnt/c/Users/intel/AppData/Local/Programs/Python/Python311/python.exe |
Comment on lines
+995
to
+997
| docker compose -f src/docker-compose-wsl2.yml exec lp-pipeline-runner \ | ||
| grep -n 'gvawatermark.*videoconvert.*autovideosink' \ | ||
| /home/pipeline-server/pipelines/pipeline.sh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



PR Checklist
What are you changing?
Issue this PR will close
close: #issue_number
Anything the reviewer should know when reviewing this PR?
Test Instructions if applicable
If the there are associated PRs in other repositories, please link them here (i.e. intel-retail/loss-prevention )
Need performance tools PR merged before merging current PR
LINK:
intel-retail/performance-tools#255