feat: Update go-github to v89#3526
Conversation
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
|
👋 Hi, and thank you for this contribution! This repo is maintained by GitHub and community members on a best-effort basis. We'll get to this as soon as we can. You can help us prioritize by joining the discussion on open issues and PRs, sharing details on the changes you need, and reviewing other contributions. 🤖 This is an automated message. |
stevehipwell
added
Type: Bug
| }) | ||
|
|
||
| return varName | ||
| // return varName |
There was a problem hiding this comment.
question: Leftover or accidental commit of debugging?
There was a problem hiding this comment.
Intentional, it should return this but as it's not used yet I get a linting error.
| // func mustCreateTestRepositoryDependabotSecret(t *testing.T, repo *github.Repository, name, value string) string { | ||
| // t.Helper() | ||
|
|
||
| // publicKey := mustGetRepositoryDependabotPublicKey(t, repo) | ||
|
|
||
| // encryptedBytes, err := encryptPlaintext(value, publicKey.GetKey()) | ||
| // if err != nil { | ||
| // t.Fatalf("failed to encrypt plaintext for test repository dependabot secret: %v", err) | ||
| // } | ||
| // encryptedValue := base64.StdEncoding.EncodeToString(encryptedBytes) | ||
|
|
||
| // if _, err := testAccConf.meta.v3client.Dependabot.CreateOrUpdateRepoSecret(t.Context(), testAccConf.meta.name, repo.GetName(), &github.DependabotEncryptedSecret{ | ||
| // Name: name, | ||
| // KeyID: publicKey.GetKeyID(), | ||
| // EncryptedValue: encryptedValue, | ||
| // }); err != nil { | ||
| // t.Fatalf("failed to create test repository dependabot secret: %v", err) | ||
| // } | ||
|
|
||
| // return name | ||
| // } |
There was a problem hiding this comment.
question: Should this be removed or added a note to it?
There was a problem hiding this comment.
I'm not sure it needs a note, it's left here for when it's needed.
2 participants
Resolves #ISSUE_NUMBER
Before the change?
After the change?
go-githubtov89.0.0Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!