chore: Add suppress diff func for unordered list

[stevehipwell]

Resolves #ISSUE_NUMBER

---

Before the change?

• Suppressing unordered list diffs required implementing for each type

After the change?

• Added suppressUnorderedListDiff function that supports suppressing diffs for lists using identity based ordering
• github_organization_ruleset & github_repository_ruleset use the new function

Pull request checklist

• Schema migrations have been created if needed (example)
• Tests for the changes have been added (for bug fixes / features)
• Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

• Yes
• No

---

[github-actions]

👋 Hi, and thank you for this contribution!

This repo is maintained by GitHub and community members on a best-effort basis. We'll get to this as soon as we can.

You can help us prioritize by joining the discussion on open issues and PRs, sharing details on the changes you need, and reviewing other contributions.

---

_{🤖 This is an automated message.}

[Copilot]

Pull request overview

These provider review instructions are being used.

Findings

1. MEDIUM — bypass_actors diff suppression may not work for ID-less actors (plan diffs can persist)

   • File reference: github/util_rules.go:908
   • actor_id is optional in the schema (and may be omitted / non-int in the decoded map), but bypassActorCompareIdentity currently returns 0 whenever actor_id isn’t an int, which prevents deterministic ordering for those entries and can defeat the unordered-diff suppression.
   • Suggested fix: use the existing toInt helper and include bypass_mode as a tiebreaker (inline fix provided in comment).

2. MEDIUM — New unit test doesn’t assert the negative cases

   • File reference: github/util_rules_test.go:1450
   • Test_bypassActorCompareIdentity only fails when wantSame=true; all wantSame=false cases currently can’t fail, reducing its value as a regression test.
   • Suggested fix: add an else assertion for wantSame=false (inline fix provided in comment).

Changes:

• Added a reusable suppressUnorderedListDiff helper for suppressing diffs on unordered TypeList fields via a caller-provided comparator.
• Replaced ruleset bypass_actors diff suppression to use the new helper and a dedicated bypass-actor comparator.
• Added a unit test for the bypass-actor comparator.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
github/util_diff.go	Adds generic unordered-list diff suppression helper used by schema fields.
github/util_rules.go	Replaces bypass-actors diff suppression logic with a comparator-based identity sort.
github/util_rules_test.go	Adds unit coverage for the bypass-actor comparator.
github/resource_github_repository_ruleset.go	Switches bypass_actors to use suppressUnorderedListDiff.
github/resource_github_organization_ruleset.go	Switches bypass_actors to use suppressUnorderedListDiff.

[deiga]

LGTM!