Skip to content

Refactor/migrate resource GitHub issue labels to tflog and context#3508

Open
slymanmrcan wants to merge 2 commits into
integrations:mainfrom
slymanmrcan:refactor/migrate-resource-github-issue-labels-to-tflog-and-context
Open

Refactor/migrate resource GitHub issue labels to tflog and context#3508
slymanmrcan wants to merge 2 commits into
integrations:mainfrom
slymanmrcan:refactor/migrate-resource-github-issue-labels-to-tflog-and-context

Conversation

@slymanmrcan

Copy link
Copy Markdown
Contributor

Addresses parts of #3070
Addresses parts of #2996


Before the change?

-resource_github_issue_labels uses legacy Create/Read/Update/Delete
schema functions and log.Printf for logging.

  • CRUD operations created their own background context.

After the change?

  • Migrated to CreateContext/ReadContext/UpdateContext/DeleteContext
  • Function signatures updated to (ctx context.Context, d *schema.ResourceData, meta any) diag.Diagnostics
  • Replaced log.Printf with tflog structured logging
  • Removed manual context.Background() calls
  • Wrapped error returns with diag.FromErr()
  • Converted error returns to diag.FromErr() / diag.Errorf() where appropriate.

Pull request checklist

  • Schema migrations have been created if needed — N/A, no schema change
  • Tests for the changes have been added — N/A, no behavior change
  • Docs have been reviewed and added / updated if needed — N/A

Does this introduce a breaking change?

  • No

@github-actions

Copy link
Copy Markdown

👋 Hi, and thank you for this contribution!

This repo is maintained by GitHub and community members on a best-effort basis. We'll get to this as soon as we can.

You can help us prioritize by joining the discussion on open issues and PRs, sharing details on the changes you need, and reviewing other contributions.


🤖 This is an automated message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant