feat: Adding github_organization_ip_allow_list_entry resource#2650
Closed
ErikElkins wants to merge 2 commits into
Closed
feat: Adding github_organization_ip_allow_list_entry resource#2650ErikElkins wants to merge 2 commits into
ErikElkins wants to merge 2 commits into
Conversation
|
any ETA when this will be released? |
|
any update on this one? |
we're also eagerly awaiting this release -- any update on ETA? |
ErikElkins
changed the title
|
+1 on this |
1 similar comment
|
+1 on this |
deiga
requested changes
Jan 17, 2026
Comment on lines
+14
to
+17
| Create: resourceGithubOrganizationIpAllowListEntryCreate, | ||
| Read: resourceGithubOrganizationIpAllowListEntryRead, | ||
| Update: resourceGithubOrganizationIpAllowListEntryUpdate, | ||
| Delete: resourceGithubOrganizationIpAllowListEntryDelete, |
Collaborator
There was a problem hiding this comment.
Please use Context-aware functions here
| Importer: &schema.ResourceImporter{ | ||
| StateContext: schema.ImportStatePassthroughContext, | ||
| }, | ||
|
|
Collaborator
There was a problem hiding this comment.
Please add a top-level Description field
|
|
||
| client := meta.(*Owner).v4client | ||
| orgName := meta.(*Owner).name | ||
| ctx := context.WithValue(context.Background(), ctxId, d.Id()) |
Collaborator
There was a problem hiding this comment.
This is not used
Suggested change
| ctx := context.WithValue(context.Background(), ctxId, d.Id()) |
| PreCheck: func() { | ||
| testAccPreCheckOrg(t) | ||
| }, | ||
| Providers: testAccProviders, |
Collaborator
There was a problem hiding this comment.
Suggested change
| Providers: testAccProviders, | |
| ProviderFactories: providerFactories, |
|
|
||
| resource.Test(t, resource.TestCase{ | ||
| PreCheck: func() { | ||
| testAccPreCheckOrg(t) |
Collaborator
There was a problem hiding this comment.
Suggested change
| testAccPreCheckOrg(t) | |
| skipUnlessHasOrgs(t) |
Comment on lines
+83
to
+86
| provider "github" { | ||
| owner = "%s" | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
The provider comes from the test, it should not be set in the config
Suggested change
| provider "github" { | |
| owner = "%s" | |
| } |
Comment on lines
+190
to
+193
| err := client.Mutate(ctx, &mutation, input, nil) | ||
| if err != nil { | ||
| return err | ||
| } |
Collaborator
There was a problem hiding this comment.
question: Is it possible for this fail with something like a 404?
| return err | ||
| } | ||
|
|
||
| return resourceGithubOrganizationIpAllowListEntryRead(d, meta) |
Collaborator
There was a problem hiding this comment.
There are no Computed fields, this is not necessary
Suggested change
| return resourceGithubOrganizationIpAllowListEntryRead(d, meta) | |
| return nil |
|
|
||
| d.SetId(string(mutation.CreateIpAllowListEntry.IpAllowListEntry.ID)) | ||
|
|
||
| return resourceGithubOrganizationIpAllowListEntryRead(d, meta) |
Collaborator
There was a problem hiding this comment.
There are no Computed fields, this is not necessary
Suggested change
| return resourceGithubOrganizationIpAllowListEntryRead(d, meta) | |
| return nil |
github-project-automation
Bot
moved this from 👀 In review
to 🏗 In progress
in 🧰 Octokit Active
Contributor
Author
|
Closing this in favor of #3443 |
github-project-automation
Bot
moved this from 🏗 In progress
to ✅ Done
in 🧰 Octokit Active
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2648
Before the change?
After the change?
github_organization_ip_allow_list_entryresource.Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!