Skip to content

Audit: reduce status parsing duplication#18

Closed
integrate-your-mind wants to merge 1 commit into
fix/activity-statefrom
audit/pr-6-fix-activity-state-20260203
Closed

Audit: reduce status parsing duplication#18
integrate-your-mind wants to merge 1 commit into
fix/activity-statefrom
audit/pr-6-fix-activity-state-20260203

Conversation

@integrate-your-mind

@integrate-your-mind integrate-your-mind commented Feb 3, 2026

Copy link
Copy Markdown
Owner

Summary

  • consolidate OpenCode status parsing to avoid duplicated regex checks
  • add PR audit report

Audit Report

  • docs/pr-audits/pr-6-fix-activity-state-20260203.md

Testing

  • not run (not requested)

Open with Devin

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional flags.

Open in Devin Review

@openclaw-consensus-bot

Copy link
Copy Markdown

Stale-work sweep update: CI failure root cause confirmed.

npm run test fails in GitHub Actions because bash does not expand tests/unit/**/*.test.ts (globstar off by default), so Node receives a literal path and exits.

Verified locally on this PR branch:

  • cherry-picked commit cf91d423b8ee405a89cd6a8fe871199c4555e440
  • commit adds scripts/run-node-tests.js and updates package.json test scripts
  • npm run test passes end-to-end

Unblock action: cherry-pick cf91d42 onto this PR branch and push.

Note: this bot cannot push to integrate-your-mind/consensus-cli (403 permission denied).

Copy link
Copy Markdown
Owner Author

Closing as stale. This branch diverged from the current #6 head and is now 23 commits behind it. Its only unique implementation is an untested deriveStatusFlags refactor in src/scan.ts, plus a dated audit note. The idea remains available in commit bb19bda67b891c95d602bd3d7273d2fd51a76a2b, but it should be reimplemented with direct unit coverage against the current scanner rather than merged from this old branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants