Feature/#3121 moodle plugin drag and drop doesn't work by AlexanderW-IL · Pull Request #102 · integral-learning/moodle-mod_mumie

AlexanderW-IL · 2026-06-09T12:32:58Z

No description provided.

…Controller to align with existing single-select architecture

…ld name, append lang suffix to taskurl

…lugin-Drag-and-Drop-doesn't-work

…) call and improve task selection label

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

dung238 · 2026-06-20T21:44:48Z

the changelog still needs to be updated

dung238 · 2026-06-22T22:57:51Z

there is still drag-and-drop code present which should be removed

Exclude mumie_selected_tasks, mumie_selected_task_properties, task_display_element and mumie_org to mumie_update_multiple_tasks trigger during multi-task creation.

dung238 · 2026-06-23T22:44:55Z

related to the other comment:

if a user edits an existing mumie task, the user can still use multi-problem-selection.
This will result in strange behavior the way it is implemented now: tasks selected via multi-problem-selection are not shown to the user, but will be created after submitting. not sure what happens if you do both a single-selection and select a different problem, followed by multi-selection.
If the single-selection is cleaned as suggested in the comment, the user sees a cleaned single-selection and the multi-selection summary suggesting the existing mumie task will be replaced. the additional problems will be created, but this doesn't trigger anything for the existing task. Maybe we should disable the multi-selection button if the user is editing an existing mumie task?

…constants

AlexanderW-IL · 2026-06-24T09:19:01Z

there is still drag-and-drop code present which should be removed

Done.

…elect is selected.

…elect switch

AlexanderW-IL · 2026-06-24T11:03:28Z

related to the other comment:

if a user edits an existing mumie task, the user can still use multi-problem-selection. This will result in strange behavior the way it is implemented now: tasks selected via multi-problem-selection are not shown to the user, but will be created after submitting. not sure what happens if you do both a single-selection and select a different problem, followed by multi-selection. If the single-selection is cleaned as suggested in the comment, the user sees a cleaned single-selection and the multi-selection summary suggesting the existing mumie task will be replaced. the additional problems will be created, but this doesn't trigger anything for the existing task. Maybe we should disable the multi-selection button if the user is editing an existing mumie task?

We deactivated the multi-select-butten if we editing a task.

AlexanderW-IL · 2026-06-26T09:45:31Z

the changelog still needs to be updated

Updated.

AlexanderW-IL and others added 15 commits June 1, 2026 16:01

implement multi slect without drag and drop

abaed88

update info text, fix bug with worksheets withc deadline and cnacle

97fa8c8

remove dead DnD Code

be18330

add SSO for multi seelct

0ca2dd5

Move multi-task creation logic from problemSelectorController to task…

9e74412

…Controller to align with existing single-select architecture

cleanup, renaming parameter remove dead code,

05d2114

cleanup, renaming incorrect and inconsistent var,

9585899

last fixes, rename inconsistent vars,

a522bfd

Fix multi-task creation: read isGraded per task, correct isgraded fie…

d026734

…ld name, append lang suffix to taskurl

Add localization for task count label, bump version to v1.9.2

5125845

Merge remote-tracking branch 'origin/dev' into feature/#3121-Moodle-P…

8bdcfdd

…lugin-Drag-and-Drop-doesn't-work

fix git pipeline issues

6295c6d

Fix server URL normalization for multi-select task creation

b04b45d

Fix lang key ordering, remove misplaced multiTaskEditController.init(…

16c61a3

…) call and improve task selection label

Rebuild AMD build files

77b0cf6

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

wip reuse single problem select

c95081d

dung238 reviewed Jun 22, 2026

View reviewed changes

Comment thread version.php Outdated

Comment thread db/services.php Outdated

Comment thread externallib.php Outdated

Comment thread externallib.php Outdated

Fix FORM_MECHANIC_FIELDS in form_field_decoder

6625b09

Exclude mumie_selected_tasks, mumie_selected_task_properties, task_display_element and mumie_org to mumie_update_multiple_tasks trigger during multi-task creation.

dung238 reviewed Jun 23, 2026

View reviewed changes

Comment thread amd/src/mod_form.js Outdated

Comment thread amd/src/mod_form.js

AlexanderW-IL added 3 commits June 24, 2026 10:18

Fix form_field_decoder: handle multiselect fields and split mechanic …

2b32786

…constants

Fix, Type error depending on completionexpected.

0b35699

Rename, tasks to mumie_tasks.

70ccc73

AlexanderW-IL added 4 commits June 24, 2026 11:28

Remove dead DnD Code.

2a60d85

Refactoring, reuse buildUrl instead copy Code.

56c4e6e

empty Name, MUMIE course, MUMIE problem, field inf form, when multi s…

54fde32

…elect is selected.

Disable multi-select button in edit mode and clear fields on multi-s…

4603f7e

…elect switch

AlexanderW-IL added 4 commits June 24, 2026 12:35

Deuglyfie Error Messages mod_form.

e3d8579

Rework Error message into modal.

34a4a57

Rework Error message into modal.

41e0a78

Rework Error message.

ae6b5ea

rename Notification to notification to avoid global overwriting.

9aaa23a

dung238 reviewed Jun 25, 2026

View reviewed changes

Comment thread mod_form.php Outdated

Comment thread amd/src/mod_form.js Outdated

Comment thread amd/src/mod_form.js Outdated

Comment thread amd/src/mod_form.js Outdated

AlexanderW-IL added 4 commits June 25, 2026 13:54

Moved to clean_up_duration_values locallib.php

aa7927e

Refactor addMessageListener: unify try/catch coverage

f04922f

Move taskList margin from inline JS style to styles.css

2cb4317

Rename taskCountLabel/label to summaryHeading/headingText

102501f

dung238 reviewed Jun 25, 2026

View reviewed changes

Comment thread externallib.php Outdated

Comment thread externallib.php

AlexanderW-IL added 3 commits June 25, 2026 15:47

Update Changelog.

2f16cdf

Add use statements for mod_mumie classes in externallib.php

62f3bcd

● Remove redundant require_once for lib.php in externallib.php

8d518d0

dung238 reviewed Jun 25, 2026

View reviewed changes

Comment thread changelog.md Outdated

dung238 reviewed Jun 26, 2026

View reviewed changes

Comment thread changelog.md Outdated

AlexanderW-IL added 3 commits June 26, 2026 10:18

Updated changelog.md

4cc84f4

Remove Error Message line from Changed Section in readme.

e5ca408

Reset Version.

e04bd00

dung238 approved these changes Jun 26, 2026

View reviewed changes

update SSO info in changelog.md.

7fe56fc

dung238 approved these changes Jun 26, 2026

View reviewed changes

AlexanderW-IL merged commit 9e2ce5c into dev Jun 26, 2026
10 checks passed

dung238 deleted the feature/#3121-Moodle-Plugin-Drag-and-Drop-doesn't-work branch June 29, 2026 11:47

Uh oh!

Conversation

AlexanderW-IL commented Jun 9, 2026

Uh oh!

dung238 commented Jun 20, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dung238 commented Jun 22, 2026

Uh oh!

Uh oh!

Uh oh!

dung238 commented Jun 23, 2026

Uh oh!

AlexanderW-IL commented Jun 24, 2026

Uh oh!

AlexanderW-IL commented Jun 24, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AlexanderW-IL commented Jun 26, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants