Feature/#2772 remove option to send personal user data - #47
Open
sabgre wants to merge 6 commits into
Open
Conversation
The admin setting to share a user's first name, last name, or e-mail address with MUMIE servers is removed. SSO now only ever transmits a pseudonymous user id. Includes a migration that purges the corresponding setting from existing installations
Restore alphabetical ordering of the implemented interfaces on multiple lines, as it was before being collapsed onto a single line, fixing the CodeSniffer error and the resulting line-length warning.
- prelogout.php, verifyToken.php, publicKey.php: suppress moodle.Files.RequireLogin.Missing. These are token-authenticated endpoints called by external MUMIE servers, not Moodle sessions, so require_login() does not apply. - lib.php, db/upgrade.php: remove the MOODLE_INTERNAL guard, per moodle.Files.MoodleInternal.MoodleInternalNotNeeded.
dung238
reviewed
Jul 28, 2026
Reverting the version bump broke the moodle-plugin-ci savepoints check, since the PII migration's upgrade savepoint requires plugin->version >= 2026072100. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
dung238
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.