Skip to content

Feature/#5064 ensure compatibility 11 #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sabgre merged 5 commits into from
Jul 10, 2026
Merged

Feature/#5064 ensure compatibility 11 #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4372508
Ensure compatibility with Ilias 11
sabgre Jul 3, 2026
1661475
Harden prelogout.php against reflected XSS
sabgre Jul 3, 2026
d7a8d0c
prepare release: finalize changelog
sabgre Jul 7, 2026
6c66830
Guard against array-shaped logoutUrl/redirect params, add JSON_THROW_…
sabgre Jul 7, 2026
9ad3170
Address review: keep version/changelog pinned until release
sabgre Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
strategy:
fail-fast: false
matrix:
php: [ '8.2', '8.3' ]
php: [ '8.3', '8.4' ]

steps:
- name: Checkout
Expand Down
7 changes: 7 additions & 0 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@

All important changes to this plugin will be documented in this file.

## TODO
### Changed
- Plugin now supports Ilias 11.1

### Removed
- Plugin no longer supports Ilias 10

## [v5.0] - 2026-06-02
### Changed
- Plugin now supports Ilias 10.7
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"require": {
"php": ">=8.1"
"php": ">=8.3"
},
"require-dev": {
"friendsofphp/php-cs-fixer": "^3.0",
Expand Down
4 changes: 2 additions & 2 deletions plugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@

// ilias min and max version; must always reflect the versions that should
// run with the plugin
$ilias_min_version = '10.0';
$ilias_max_version = '10.99';
$ilias_min_version = '11.0';
$ilias_max_version = '11.99';

// optional, but useful: Add one or more responsible persons and a contact email
$responsible = 'Tobias Goltz';
Expand Down
12 changes: 9 additions & 3 deletions prelogout.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,18 @@
* @author Tobias Goltz (tobias.goltz@integral-learning.de)
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
$logouturls = $_GET['logoutUrl'];
$redirect = json_encode($_GET['redirect']);
const JSON_ENCODE_FOR_SCRIPT = JSON_HEX_TAG | JSON_HEX_APOS | JSON_HEX_QUOT | JSON_HEX_AMP | JSON_THROW_ON_ERROR;

$raw_logout_url = $_GET['logoutUrl'] ?? '';
$decoded_logout_urls = is_string($raw_logout_url) ? json_decode($raw_logout_url, true) : null;
$logout_urls = is_array($decoded_logout_urls) ? array_values(array_filter($decoded_logout_urls, 'is_string')) : [];

$raw_redirect = $_GET['redirect'] ?? '';
$redirect = json_encode(is_string($raw_redirect) ? $raw_redirect : '', JSON_ENCODE_FOR_SCRIPT);
?>

<script>
const logouturls = Object.values(<?php echo $logouturls; ?>);
const logouturls = Object.values(<?php echo json_encode($logout_urls, JSON_ENCODE_FOR_SCRIPT); ?>);
const promises = [];
logouturls.forEach(function (url) {
promises.push(logoutFromServer(url));
Expand Down