Skip to content

Feature/#2773 align token creation with other lms plugins #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sabgre wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

Feature/#2773 align token creation with other lms plugins #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4dd6cf4
Align SSO token verification window with other LMS plugins
sabgre Jul 27, 2026
8ea4217
Add changelog entry for SSO token verification window fix
sabgre Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

All important changes to this plugin will be documented in this file.

## TODO
### Changed
- Tightened the SSO token verification window from 1 hour to 60 seconds, matching the other LMS plugin implementations

## [v1.5] - 2021-10-22
### Added
- Ungraded MUMIE Tasks are now supported in Stud.IP. They represent ungraded links to MUMIE articles.
Expand Down
2 changes: 1 addition & 1 deletion services/SSOService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ public static function verifyToken($token, $hashedId)

if (!is_null($mumieToken) && $mumieToken->token == $token && $userRecord != null) {
$current = time();
if (($current - $mumieToken->timecreated) >= (60*60)) {
if (($current - $mumieToken->timecreated) >= 60) {
$response->status = "invalid";
} else {
$response->status = "valid";
Expand Down