Feature/#4926 studip 6 migration - #8
Draft
Lyannic wants to merge 5 commits into
Draft
Conversation
Stud.IP 6 removed app/controllers/plugin_controller.php; the base
controllers (StudipController/PluginController) now live under
lib/classes/ and are PSR-autoloaded. The hard-coded require_once
therefore fatals ("Failed opening required") as soon as any of the
plugin's controllers is dispatched. Dropping it lets the autoloader
resolve the base classes.
The create-server view never set the name/url_prefix attributes for the shared ServerForm.php template and referenced an undefined $server when building the action link. Under PHP 8 these undefined variables are warnings that get rendered into the form (e.g. into the input value attributes). A new server has no id, so seed the fields empty and drop the server_id from the action link.
The create-task view only set a subset of the attributes that the shared TaskForm.php template reads (editTask sets them all). Under PHP 8 the missing ones are warnings rendered into the form, and the uninitialised duedate triggers a TypeError because TaskForm.php passes it to date(), which no longer accepts a string. Seed every field the template expects, with duedate as int 0.
When a server's course JSON omits the "link" property, reading it raised an undefined-property warning under PHP 8 (silent in PHP 7). A null link is already handled in addCourseTask(), so coalesce to null.
Config::store() takes the field name as a string, but the privacy and authentication actions passed MUMIE_ORG / MUMIE_API_KEY / MUMIE_SHARE_* as bare words. PHP 7 coerced the undefined constants to their string names (with a notice); PHP 8 makes that a fatal "Undefined constant" error when saving the settings. Quote them.
Lyannic
force-pushed
the
feature/#4926-studip-6-migration
branch
from
June 2, 2026 18:38
325cddd to
143d23e
Compare
AlexanderW-IL
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.