Skip to content

Spanish translation - #43

Open
pedritomelenas wants to merge 4 commits into
integr-abile:developfrom
pedritomelenas:develop
Open

Spanish translation#43
pedritomelenas wants to merge 4 commits into
integr-abile:developfrom
pedritomelenas:develop

Conversation

@pedritomelenas

Copy link
Copy Markdown

Just in case you want to have a look at how the messages look like in Spanish

@netlify

netlify Bot commented Dec 21, 2024

Copy link
Copy Markdown

Deploy Preview for audiofunctions ready!

Name Link
🔨 Latest commit 85b921c
🔍 Latest deploy log https://app.netlify.com/sites/audiofunctions/deploys/677679412d89f40008bc5a96
😎 Deploy Preview https://deploy-preview-43--audiofunctions.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@integr-abile

Copy link
Copy Markdown
Owner

Hi Pedro, thank you for the PR. I checked your code and I found 2 errors leading your build fail (I tried on my PC)

  • You changed the yarn.lock file from the base version. Please copy and paste the yarn.lock content of my last commit on the develop branch(458c958)
  • You added the "vue-loader" dependency to the package.json file. Just remove it

Furthermore, in order to work with the same node version of the web build environment (Netlify), on your machine you should use node version 16.19.0. I use node version manager (nvm) to have more node versions on my pc and switch between them based on the project I'm working on

@pedritomelenas

Copy link
Copy Markdown
Author

Done. I did not translate the whole README.md. I think it should be a good idea to have it in English with more explanations.

@pedritomelenas

pedritomelenas commented Jan 2, 2025

Copy link
Copy Markdown
Author

I just noticed that there are still more Italian messages in the demo. I will do a search through all the files and will translate them to Spanish. The same might happen with the English translation.

@pedritomelenas

Copy link
Copy Markdown
Author

Added all the translations to messages that I spotted while browsing through the different menus of the app.

@integr-abile

integr-abile commented Jan 2, 2025

Copy link
Copy Markdown
Owner

Checked it! Thank you! As we did for the english version, is it ok for you if we keep the spanish version in this branch instead of merging to develop (or main)?

@pedritomelenas

Copy link
Copy Markdown
Author

I did not notice there was a branch for the English version, sorry. I guess that it can be a good idea to create a branch for the Spanish localization, but proceed as you prefer.
We should think about an alternate way of localizing the app to different languages. May be POEditor? This is the option chosen by Numbas: https://www.numbas.org.uk/contributing-to-numbas/#:~:text=Numbas%20supports%20full%20localisation.,translating%20Numbas%20into%20your%20language.

@integr-abile

Copy link
Copy Markdown
Owner

I would leave this PR open and we can keep this branch for the spanish translation. I would not invest more effort in this project including a full approach like the Poedit one. At least not now. I would wait the Audiofunctions+ development. Do you agree?

@pedritomelenas

Copy link
Copy Markdown
Author

Fine with me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants