Updating Escape Quote Replacement and Tests - #236
Open
Niiiiiic wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
When using the Sage Intacct SDK comparison classes for strings, single quotes were not being escaped. For example, the string "Bob's Pizza, Inc." would be converted to "Bob's Pizza, Inc." instead of "Bob\'s Pizza, Inc.". This change updates the value "\'" with "\\'" in each string.Replace(), so that the single quote can be properly escaped. The tests for escaped single quotes were also updated to reflect this change.
Testing
Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
[xUnit.net 00:00:41.82] Intacct.SDK.Tests.Xml.RequestHandlerTest.MockExecuteWithDebugLoggerTest [SKIP]
[xUnit.net 00:00:41.82] Intacct.SDK.Tests.OnlineClientTest.LoggerTest [SKIP]
Skipped Intacct.SDK.Tests.Xml.RequestHandlerTest.MockExecuteWithDebugLoggerTest [1 ms]
Skipped Intacct.SDK.Tests.OnlineClientTest.LoggerTest [1 ms]
[xUnit.net 00:00:41.82] Intacct.SDK.Tests.Xml.RequestHandlerTest.MockExecuteOfflineWithSessionCredsTest [SKIP]
Skipped Intacct.SDK.Tests.Xml.RequestHandlerTest.MockExecuteOfflineWithSessionCredsTest [1 ms]
Passed! - Failed: 0, Passed: 497, Skipped: 3, Total: 500, Duration: 205 ms - Intacct.SDK.Tests.dll (netcoreapp3.1)