Skip to content

feat(ui-modal): add margin to fullscreen modal#2608

Draft
git-nandor wants to merge 1 commit into
masterfrom
INSTUI-5067_add_margin_to_modal
Draft

feat(ui-modal): add margin to fullscreen modal#2608
git-nandor wants to merge 1 commit into
masterfrom
INSTUI-5067_add_margin_to_modal

Conversation

@git-nandor

@git-nandor git-nandor commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

INSTUI-5067

Summary

A size="fullscreen" Modal previously covered the entire viewport edge-to-edge, making it hard to tell it was a modal.

Changes

  • Modal applies fullScreenMargin (new token) based on sharedTokens.breakpoints (new token).
  • The Small viewports docs example now uses a theme override to simulate the small viewport media query behavior.
  • The Constraining Modal to a parent element section example was updated to fix the scrollbar introduced by the new margin changes by increasing its size.
  • prettier@3.8.1 pulled by new style-dictionary@4.4.0 caused conflicts with ui-codemods. Fixed by adding "prettier": "2.8.8" to the root package.json.

Test plan

Check the Modal page Media Modal example with default (fullscreen, cover) settings.

  • Large screen (≥ 768px): it is inset on all sides, rounded corners + shadow, backdrop visible around it.
  • Small screen (< 768px): edge-to-edge, no margin/radius.

Co-Authored-By: 🤖 Claude

@git-nandor git-nandor changed the title feat(ui-modal): on larger screens, inset the fullscreen modal from th… feat(ui-modal): add margin to fullscreen modal Jun 24, 2026
@git-nandor git-nandor force-pushed the INSTUI-5067_add_margin_to_modal branch from 45e97b7 to e015aee Compare June 24, 2026 15:13
@git-nandor git-nandor self-assigned this Jun 24, 2026
@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown
PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://instructure.design/pr-preview/pr-2608/

Built to branch gh-pages at 2026-06-25 10:55 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@github-actions

Copy link
Copy Markdown

Visual regression report

No changes.

Status Count
Unchanged 32
Changed 0
New 0
Removed 0

📊 View full report

Baselines come from the visual-baselines branch. They refresh on every merge to master.

github-actions Bot pushed a commit that referenced this pull request Jun 24, 2026
…e viewport edge for a11y, fix prettier version mismatch because of the style-dictionary@4.4.0
@git-nandor git-nandor force-pushed the INSTUI-5067_add_margin_to_modal branch from e015aee to 5893625 Compare June 25, 2026 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant