feat(ui-modal): add margin to fullscreen modal#2608
Draft
git-nandor wants to merge 1 commit into
Draft
Conversation
45e97b7 to
e015aee
Compare
|
Visual regression report✅ No changes.
Baselines come from the |
…e viewport edge for a11y, fix prettier version mismatch because of the style-dictionary@4.4.0
e015aee to
5893625
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INSTUI-5067
Summary
A
size="fullscreen"Modal previously covered the entire viewport edge-to-edge, making it hard to tell it was a modal.Changes
fullScreenMargin(new token) based onsharedTokens.breakpoints(new token).prettier@3.8.1pulled by newstyle-dictionary@4.4.0caused conflicts with ui-codemods. Fixed by adding "prettier": "2.8.8" to the root package.json.Test plan
Check the Modal page Media Modal example with default (fullscreen, cover) settings.
Co-Authored-By: 🤖 Claude